Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DotNet Pack #142

Merged
merged 1 commit into from
Feb 27, 2021
Merged

Fix DotNet Pack #142

merged 1 commit into from
Feb 27, 2021

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 馃懏.
  • I have provided test coverage for my change (where applicable)

Description

We were missing config settings following the upgrade I did in #141

Successful packing has been tested and confirmed locally.

@codecov
Copy link

codecov bot commented Feb 27, 2021

Codecov Report

Merging #142 (608c84f) into master (451da15) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   84.57%   84.64%   +0.07%     
==========================================
  Files          46       46              
  Lines        1368     1368              
  Branches      177      177              
==========================================
+ Hits         1157     1158       +1     
+ Misses        163      162       -1     
  Partials       48       48              
Flag Coverage 螖
unittests 84.64% <酶> (+0.07%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
.../ImageSharp.Web/Middleware/ImageSharpMiddleware.cs 88.25% <0.00%> (+0.37%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 451da15...608c84f. Read the comment docs.

@JimBobSquarePants JimBobSquarePants merged commit 7ab73bb into master Feb 27, 2021
@JimBobSquarePants JimBobSquarePants deleted the js/fix-license-config branch February 27, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant