Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapting log level when files are not found #148

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

sebastienros
Copy link
Contributor

@sebastienros sebastienros commented Mar 23, 2021

Fixes #143

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 馃懏.
  • I have provided test coverage for my change (where applicable)

Description

Error is too intrusive and these events are too common, the event log can then fill up quickly. Moving it to Debug since this is what aspnet uses for the standard static file provider on these events.

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #148 (9908d55) into master (7ab73bb) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
- Coverage   84.64%   84.57%   -0.08%     
==========================================
  Files          46       46              
  Lines        1368     1368              
  Branches      177      177              
==========================================
- Hits         1158     1157       -1     
- Misses        162      163       +1     
  Partials       48       48              
Flag Coverage 螖
unittests 84.57% <100.00%> (-0.08%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
src/ImageSharp.Web/Middleware/LoggerExtensions.cs 87.09% <100.00%> (酶)
.../ImageSharp.Web/Middleware/ImageSharpMiddleware.cs 87.87% <0.00%> (-0.38%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 7ab73bb...9908d55. Read the comment docs.

@JimBobSquarePants
Copy link
Member

Perfect. Thanks!

@JimBobSquarePants JimBobSquarePants merged commit d055952 into SixLabors:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong log level for non-existent files
2 participants