Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update target framework, infrastructure, and fix build warnings #303

Merged
merged 6 commits into from
Feb 14, 2023

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

  • Update Shared-Infrastructure submodule
  • Update Target Framework to .NET 6
  • Enable nullable reference types (disabled per file)
  • Fix various build warnings.
  • Changed license and updated readme.

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #303 (c54b149) into main (6943275) will increase coverage by 0%.
The diff coverage is 85%.

@@         Coverage Diff         @@
##           main   #303   +/-   ##
===================================
  Coverage    85%    85%           
===================================
  Files        76     76           
  Lines      2173   2166    -7     
  Branches    304    300    -4     
===================================
- Hits       1859   1857    -2     
+ Misses      229    228    -1     
+ Partials     85     81    -4     
Flag Coverage Δ
unittests 85% <85%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/ImageSharp.Web/Providers/WebRootImageProvider.cs 0% <0%> (ø)
...ching/LruCache/TLruLongTicksPolicy{TKey,TValue}.cs 21% <21%> (-6%) ⬇️
...geSharp.Web.Providers.AWS/AmazonS3ClientFactory.cs 31% <27%> (ø)
...ching/LruCache/ConcurrentTLruCache{TKey,TValue}.cs 43% <46%> (ø)
...oviders.AWS/Providers/AWSS3StorageImageProvider.cs 67% <66%> (ø)
src/ImageSharp.Web/ImageMetadata.cs 66% <66%> (ø)
...Sharp.Web/Commands/QueryCollectionRequestParser.cs 71% <71%> (ø)
...b/Commands/Converters/SimpleCommandConverter{T}.cs 75% <75%> (ø)
.../Synchronization/RefCountedConcurrentDictionary.cs 76% <76%> (ø)
...s.Azure/Providers/AzureBlobStorageImageProvider.cs 77% <76%> (ø)
... and 104 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JimBobSquarePants JimBobSquarePants merged commit d91883f into main Feb 14, 2023
@JimBobSquarePants JimBobSquarePants mentioned this pull request Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant