Prevent concurrent modification when iterating request commands #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimBobSquarePants
approved these changes
Sep 10, 2019
| @@ -157,7 +157,8 @@ public async Task Invoke(HttpContext context) | |||
| IDictionary<string, string> commands = this.requestParser.ParseRequestCommands(context); | |||
| if (commands.Count > 0) | |||
| { | |||
| foreach (string command in commands.Keys) | |||
| List<string> commandKeys = new List<string>(commands.Keys); | |||
There was a problem hiding this comment.
I would have used ToArray() here but a list will do for now.
There was a problem hiding this comment.
I dread to use System.Linq in active/hot path 馃槈
|
@lahma This is certainly critical enough to warrant a new release so here you go! 馃槃 https://www.nuget.org/packages/SixLabors.ImageSharp.Web/1.0.0-beta0009 |
|
Thanks for the prompt action and release (and sorry for the extra chore)! 馃憤 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
There was an unfortunate problem in optimization PR which surfaced in OrchardCore. Commands were mutated with active iterator and that broke the contract. This fixes the problem and hopefully you could do yet another release to NuGet 馃檹