Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create PhysicalFileProvider from Webroot #80

Merged

Conversation

deanmarcussen
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Fixes #78

I've updated PhysicalFileSystemCache to create a PhysicalFileProvider from the IHostingEnvironment.WebRootPath to work around the issues some people are experiencing in development mode with core 3

It has meant taking a reference on Microsoft.Extensions.FileProviders.Physical but I think I've got the correct versions for both targets netstandard1.4 and netstandard2.0, noting there is no released version of 1.1.2 which would match the other netstandard1.4 targets

@JimBobSquarePants
Copy link
Member

@deanmarcussen Looks good to me, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cache path isn't valid
2 participants