Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New build process #84

Merged
merged 17 commits into from
Jan 22, 2020
Merged

New build process #84

merged 17 commits into from
Jan 22, 2020

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

  • Adopts Github Actions as a build process
  • Updates dependencies
  • Move targets to sensible values.
  • Optimize no-command pipline

.github/workflows/build-and-test.yml Outdated Show resolved Hide resolved
GitVersion.yml Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 21, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@589086b). Click here to learn what that means.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #84   +/-   ##
=========================================
  Coverage          ?   75.68%           
=========================================
  Files             ?       47           
  Lines             ?     1316           
  Branches          ?      228           
=========================================
  Hits              ?      996           
  Misses            ?      256           
  Partials          ?       64
Flag Coverage Δ
#unittests 75.68% <85.71%> (?)
Impacted Files Coverage Δ
src/ImageSharp.Web/FormattedImage.cs 84.61% <ø> (ø)
...eSharp.Web/Providers/PhysicalFileSystemProvider.cs 84.21% <0%> (ø)
...s.Azure/Providers/AzureBlobStorageImageProvider.cs 76.47% <100%> (ø)
.../ImageSharp.Web/Middleware/ImageSharpMiddleware.cs 73.46% <91.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 589086b...4a4f51a. Read the comment docs.

Copy link
Member

@tocsoft tocsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@JimBobSquarePants JimBobSquarePants merged commit 4a49f4d into master Jan 22, 2020
@JimBobSquarePants JimBobSquarePants deleted the js/new-build-process branch January 22, 2020 14:08
@JimBobSquarePants JimBobSquarePants added this to the 1.0.0-rc1 milestone Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants