Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Azure stream to prevent read errors #86

Merged
merged 4 commits into from
Jan 27, 2020
Merged

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 馃懏.
  • I have provided test coverage for my change (where applicable)

Description

  • Exposes ChunkedMemoryStream as a public type.
  • Ensures entire Azure Blob stream is copied before processing.

@codecov
Copy link

codecov bot commented Jan 27, 2020

Codecov Report

Merging #86 into master will increase coverage by 0.71%.
The diff coverage is 72.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   75.83%   76.55%   +0.71%     
==========================================
  Files          47       47              
  Lines        1316     1322       +6     
  Branches      228      230       +2     
==========================================
+ Hits          998     1012      +14     
+ Misses        254      242      -12     
- Partials       64       68       +4
Flag Coverage 螖
#unittests 76.55% <72.41%> (+0.71%) 猬嗭笍
Impacted Files Coverage 螖
.../ImageSharp.Web/Middleware/ImageSharpMiddleware.cs 73.46% <100%> (酶) 猬嗭笍
...s.Azure/Resolvers/AzureBlobStorageImageResolver.cs 90% <100%> (+10%) 猬嗭笍
src/ImageSharp.Web/ChunkedMemoryStream.cs 75.48% <68.62%> (+4.94%) 猬嗭笍
...s.Azure/Providers/AzureBlobStorageImageProvider.cs 76.47% <0%> (-5.89%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 4a49f4d...cd1a16d. Read the comment docs.

@JimBobSquarePants JimBobSquarePants merged commit 666fd50 into master Jan 27, 2020
@JimBobSquarePants JimBobSquarePants deleted the js/fix-85 branch January 27, 2020 11:02
@JimBobSquarePants JimBobSquarePants added this to the 1.0.0-rc1 milestone May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant