Update shared infrastructure #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianpopow
commented
Mar 16, 2020
| { Rgba32.Orange, "orange" }, | ||
| { Rgba32.Lime, "00FF00" }, | ||
| { Color.White, "255,255,255" }, | ||
| { Color.Transparent, "0,0,0,0" }, |
There was a problem hiding this comment.
note that i have changed the expected value from transparent from 255, 255, 255,0 to 0,0,0,0 as i think that's the correct value for transparent, see: transparent
There was a problem hiding this comment.
Yep, that's correct. W3C defines transparent as 0,0,0,0 only MS use 255,255,255,0
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
==========================================
+ Coverage 76.5% 76.65% +0.15%
==========================================
Files 47 47
Lines 1311 1311
Branches 229 229
==========================================
+ Hits 1003 1005 +2
Misses 238 238
+ Partials 70 68 -2
Continue to review full report at Codecov.
|
JimBobSquarePants
approved these changes
Mar 16, 2020
| @@ -157,6 +157,7 @@ Core Team | |||
| - [Dirk Lemstra](https://github.com/dlemstra) | |||
| - [Anton Firsov](https://github.com/antonfirsov) | |||
| - [Scott Williams](https://github.com/tocsoft) | |||
| - [Brian Popow](https://github.com/brianpopow) | |||
| { Rgba32.Orange, "orange" }, | ||
| { Rgba32.Lime, "00FF00" }, | ||
| { Color.White, "255,255,255" }, | ||
| { Color.Transparent, "0,0,0,0" }, |
There was a problem hiding this comment.
Yep, that's correct. W3C defines transparent as 0,0,0,0 only MS use 255,255,255,0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Updates the shared infrastructure of the ImageSharp.Web project