Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnchorPositionMode.Center is ignored when CenterCoordinates is Empty #90

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

meixger
Copy link
Contributor

@meixger meixger commented Apr 23, 2020

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

When cropping without specifying explicit 'rxy' in the url, the CenterCoordinates will be set to PointF.Empty and the AnchorPositionMode.Center will be ignored because ResizeHelper checks for CenterCoordinates.HasValue.

@CLAassistant
Copy link

CLAassistant commented Apr 23, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thanks!

If you can please sign the CLA I'll get it merged for you.

@meixger
Copy link
Contributor Author

meixger commented Apr 23, 2020

"You have signed the CLA for multiple repositories or organizations"

I've added my commit email address to the Github profile and re-signed the CLA multiple times 🤷‍♂️
I'm stuck ...

@JimBobSquarePants
Copy link
Member

JimBobSquarePants commented Apr 23, 2020

@meixger It's probably an issue with the tooling then. I'll look into it 👍

Forcing a recheck has worked.

@JimBobSquarePants JimBobSquarePants merged commit 22e193b into SixLabors:master Apr 23, 2020
@JimBobSquarePants JimBobSquarePants added this to the 1.0.0-rc1 milestone Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants