Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RGB to HSL conversion #1001

Merged
merged 2 commits into from Sep 7, 2019
Merged

Fix RGB to HSL conversion #1001

merged 2 commits into from Sep 7, 2019

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Fixes the calculation issue discovered in #997

@codecov
Copy link

codecov bot commented Sep 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@29d7ed0). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1001   +/-   ##
=========================================
  Coverage          ?   89.77%           
=========================================
  Files             ?     1098           
  Lines             ?    48812           
  Branches          ?     3433           
=========================================
  Hits              ?    43823           
  Misses            ?     4284           
  Partials          ?      705
Impacted Files Coverage Δ
.../Colorspaces/Conversion/RgbAndHslConversionTest.cs 100% <ø> (ø)
...on/Implementation/Converters/HslAndRgbConverter.cs 98.24% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d7ed0...7aaaa25. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@29d7ed0). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1001   +/-   ##
=========================================
  Coverage          ?   89.66%           
=========================================
  Files             ?     1098           
  Lines             ?    48810           
  Branches          ?     3433           
=========================================
  Hits              ?    43766           
  Misses            ?     4289           
  Partials          ?      755
Impacted Files Coverage Δ
.../Colorspaces/Conversion/RgbAndHslConversionTest.cs 100% <ø> (ø)
...on/Implementation/Converters/HslAndRgbConverter.cs 98.24% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d7ed0...7aaaa25. Read the comment docs.

@JimBobSquarePants JimBobSquarePants merged commit ceff1cc into master Sep 7, 2019
ImageSharp automation moved this from To Do to Done Sep 7, 2019
@JimBobSquarePants JimBobSquarePants deleted the issue/997 branch September 7, 2019 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
ImageSharp
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants