New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify and cleanup build constants #1075
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1075 +/- ##
==========================================
+ Coverage 89.95% 89.95% +<.01%
==========================================
Files 1200 1200
Lines 53013 53010 -3
Branches 3847 3847
==========================================
- Hits 47689 47687 -2
+ Misses 4556 4555 -1
Partials 768 768
Continue to review full report at Codecov.
|
Imma gonna go ahead with this now I've consolidated the build constants. I want to move on to #1076 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm after a quick review on mobile
Prerequisites
Description
As part of the move to externalize ImageSharp.Drawing and import Core I thought it wise to simplify and normalize our use of #ifdefs throughout the library.
Once we have a CI build environment that works on .NET Core 3.1 we can easily add additional target frameworks.
Touch #1002