More Efficient ToBase64String #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1153 +/- ##
==========================================
- Coverage 82.29% 82.23% -0.06%
==========================================
Files 680 680
Lines 29301 29301
Branches 3279 3279
==========================================
- Hits 24112 24096 -16
- Misses 4500 4516 +16
Partials 689 689
Continue to review full report at Codecov.
|
antonfirsov
reviewed
Mar 25, 2020
src/ImageSharp/ImageExtensions.cs
Outdated
Comment on lines
130
to
131
| buffer.AsSpan().CopyTo(sharedBuffer); | ||
| return $"data:{format.DefaultMimeType};base64,{Convert.ToBase64String(sharedBuffer)}"; |
There was a problem hiding this comment.
Is there a reason to operate on a copy instead of ArraySegment<byte>.Array?
ToBase64String(array, offset, length) seems to be available on all platforms. I don't even think we need the BASE64SPAN define.
There was a problem hiding this comment.
Haha yes, much better. Will update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Prevents allocation of an array when saving to a Base64 encoded string.