Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNG Identify reads zTXt, iTXt and exif cunks #1187

Merged
merged 3 commits into from Apr 26, 2020
Merged

Conversation

brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This PR changes PNG Identify, so it will not ignore EXIF or zTXt, iTXt chunks.

@brianpopow brianpopow requested a review from a team April 26, 2020 17:21
@codecov
Copy link

codecov bot commented Apr 26, 2020

Codecov Report

Merging #1187 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1187      +/-   ##
==========================================
+ Coverage   82.50%   82.53%   +0.02%     
==========================================
  Files         692      692              
  Lines       29974    29983       +9     
  Branches     3389     3390       +1     
==========================================
+ Hits        24731    24746      +15     
+ Misses       4543     4540       -3     
+ Partials      700      697       -3     
Flag Coverage Δ
#unittests 82.53% <100.00%> (+0.02%) ⬆️
Impacted Files Coverage Δ
src/ImageSharp/Formats/Png/PngDecoderCore.cs 90.65% <100.00%> (+1.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2f014e...386d942. Read the comment docs.

Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted!

@brianpopow brianpopow merged commit bec0b55 into master Apr 26, 2020
@brianpopow brianpopow deleted the bp/identifyText branch April 26, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants