Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation of HorizontalResolution and VerticalResolution properties #1981

Merged
merged 1 commit into from Feb 8, 2022

Conversation

0xced
Copy link
Contributor

@0xced 0xced commented Feb 7, 2022

Also improve the formatting of the ResolutionUnits documentation.

…erties

Also improve the formatting of the ResolutionUnits documentation.
Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah JUST missed the V2 release....

This looks great, much appreciated 👍

@JimBobSquarePants JimBobSquarePants merged commit a844c78 into SixLabors:master Feb 8, 2022
@0xced 0xced deleted the fix-resolution-doc branch February 8, 2022 08:50
@0xced
Copy link
Contributor Author

0xced commented Feb 8, 2022

Too bad I just missed the v2 release!

I noticed this documentation glitch while porting the ClosedXML library from System.Drawing to ImageSharp (ClosedXML/ClosedXML#1694 (comment)). Except for this small glitch the migration is going pretty smoothly. It's really a pleasure to work with such a well engineered and well documented library. 😍

@JimBobSquarePants
Copy link
Member

Thanks! That's really great to hear!

Just had a very quick look at the port. You've got a mix of the old and new major versions of ImageSharp, Drawing, and, Fonts going on there which won't work well. I'm gonna be pushing new betas for both Fonts and Drawing today which will bring some changes (massive improvements) around text rendering. I'd strongly recommend bumping to a minimum of net472 also due the the redirect issues with older targets

@0xced
Copy link
Contributor Author

0xced commented Feb 9, 2022

Actually, Drawing is not used. Nevertheless, I updated Fonts to the latest beta (16) and it was a matter of updating IFontCollection.Install to IFontCollection.Add, IReadOnlyFontCollection.Find to IReadOnlyFontCollection.Get and RenderOptions to the new TextOptions.

I'd strongly recommend bumping to a minimum of net472 also due the the redirect issues with older targets

I'm fully aware of the issues with .NET Standard 2.0 theoretically supporting .NET Framework 4.6.1 but actually only supporting .NET Framework 4.7.2. But in such a large pull request, I prefer te be conservative with the changes to the target framework in order to focus on the rest of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants