Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduce color space as YCbCr if component id's are 1, 2, 3 #2135

Merged
merged 2 commits into from
May 30, 2022
Merged

Deduce color space as YCbCr if component id's are 1, 2, 3 #2135

merged 2 commits into from
May 30, 2022

Conversation

brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 馃懏.
  • I have provided test coverage for my change (where applicable)

Description

Another case of deducing the color space of a jpeg image based on the component id's.

Related issue #2133

@brianpopow brianpopow requested a review from a team May 29, 2022 15:19
br3aker
br3aker approved these changes May 29, 2022
View reviewed changes
Copy link
Contributor

@br3aker br3aker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Image from the issue is neither jfif nor adobe jfif, it was encoded with app1 marker which we indeed ignored during color deduction. I didn't find any information regarding jpeg encoding color type from exif specs so component id color deduction seems to be a solution.

@brianpopow
Copy link
Collaborator Author

Looks good. Image from the issue is neither jfif nor adobe jfif, it was encoded with app1 marker which we indeed ignored during color deduction. I didn't find any information regarding jpeg encoding color type from exif specs so component id color deduction seems to be a solution.

@br3aker thanks for your feedback!

antonfirsov
antonfirsov approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianpopow brianpopow merged commit 1b475ad into main May 30, 2022
@brianpopow brianpopow deleted the bp/Issue2133 branch May 30, 2022 12:52
@brianpopow brianpopow mentioned this pull request May 30, 2022
Closed
4 tasks
@JimBobSquarePants
Copy link
Member

Do you think we should backport this since we introduced the issue in the last patch?

@brianpopow
Copy link
Collaborator Author

Do you think we should backport this since we introduced the issue in the last patch?

I would not consider this a critical issue, it's more an edge case, so I don't think we need to backport this.

@brianpopow brianpopow mentioned this pull request Jun 4, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonfirsov antonfirsov antonfirsov approved these changes

@br3aker br3aker br3aker approved these changes

Assignees
No one assigned
Labels
formats:jpeg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brianpopow @JimBobSquarePants @antonfirsov @br3aker