Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify transparency for indexed PNG correctly #2215

Merged
merged 3 commits into from
Aug 29, 2022
Merged

Identify transparency for indexed PNG correctly #2215

merged 3 commits into from
Aug 29, 2022

Conversation

brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 馃懏.
  • I have provided test coverage for my change (where applicable)

Description

This PR fixes an issue that HasTransparency is not set for index PNG's.
This fixes #2209

@brianpopow brianpopow requested a review from a team August 28, 2022 12:51
@JimBobSquarePants
Copy link
Member

Thanks for this @brianpopow I tweaked it slightly to ensure that the assignment only happens when the alpha chunk has a length

@JimBobSquarePants JimBobSquarePants merged commit 1b6728b into main Aug 29, 2022
@JimBobSquarePants JimBobSquarePants deleted the bp/pngindexedtrans branch August 29, 2022 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimBobSquarePants JimBobSquarePants JimBobSquarePants approved these changes

Assignees
No one assigned
Labels
area:metadata formats:png
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GetPngMetadata does not set HasTransparency correctly for palette-based PNGs
2 participants
@brianpopow @JimBobSquarePants