Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiff: Make sure bits per pixel is set to 1 for bilevel compression #2256

Merged
merged 1 commit into from
Oct 9, 2022
Merged

Tiff: Make sure bits per pixel is set to 1 for bilevel compression #2256

merged 1 commit into from
Oct 9, 2022

Conversation

brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Make sure bits per pixel is set to 1 for bilevel compression when encoding tiff's, fixes #2255.

@brianpopow brianpopow requested a review from a team October 8, 2022 13:09
JimBobSquarePants
JimBobSquarePants approved these changes Oct 9, 2022
View reviewed changes
Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JimBobSquarePants JimBobSquarePants merged commit 9dcf12d into main Oct 9, 2022
@JimBobSquarePants JimBobSquarePants deleted the bp/Issue2255 branch October 9, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimBobSquarePants JimBobSquarePants JimBobSquarePants approved these changes

Assignees
No one assigned
Labels
formats:tiff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TiffEncoder with TiffCompression throws System.IndexOutOfRangeException
2 participants
@brianpopow @JimBobSquarePants