Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for decoding tiff images with old jpeg compression #2266

Merged
merged 20 commits into from
Oct 13, 2022
Merged

Add support for decoding tiff images with old jpeg compression #2266

merged 20 commits into from
Oct 13, 2022

Conversation

brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This PR add's support for decoding tiff images with old jpeg compression.

Related issue #2238

note: only chunky planar configuration is supported.

brianpopow and others added 15 commits September 25, 2022 19:52
@brianpopow
Add support for decoding tiff images with old jpeg compression (#2238)
db51bd7
@brianpopow
Always assume PhotometricInterpretation to be YCbCr, if the compressi…
e6d1c94 
…on is old jpeg
@brianpopow
Add test for old jpeg compression
019dae0
@brianpopow
Set PhotometricInterpretation to RGB, let jpeg decoder handle color c…
08f9063 
…onversion
@brianpopow
Only compare first frame in old jpeg compression test
be1ee58
@brianpopow
Set FrameCount from the decoding options
a4aa6b5
@brianpopow
Override PhotometricInterpretation to RGB only in case of YCbCr, for …
f171184 
…black and white it should stay as it is
@brianpopow
Fill read buffer in constructor and when IsInReadBuffer() is false
e066b83
@brianpopow
Add test for issue when setting the stream position twice
67b1693
@brianpopow
Set stream position to strip offset + stripOffsetBytes after decompre…
d1bdedd 
…ssing jpeg data
@brianpopow
Revert "Fill read buffer in constructor and when IsInReadBuffer() is …
81c3ad3 
…false"

This reverts commit e066b83.
@brianpopow
Merge remote-tracking branch 'origin/main' into bp/oldJpegCompression
10bcfb7
@brianpopow
Add old jpeg compressed tiff test with bi-color
8593ebf
@brianpopow
Throw NotSupported exception with OldJpeg+Planar config
f23fdf2
@brianpopow
Merge branch 'main' into bp/oldJpegCompression
d8f17ac
@JimBobSquarePants
Copy link
Member

@brianpopow I'll review this in the morning. 😍

@JimBobSquarePants JimBobSquarePants added this to the 3.0.0 milestone Oct 13, 2022
JimBobSquarePants
JimBobSquarePants approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few minor tweaks and switched the jpeg utils to use PixelOperations<T>.

Everything else looks great though. Thanks for working on this!

@JimBobSquarePants JimBobSquarePants merged commit 8b7eaf2 into main Oct 13, 2022
@JimBobSquarePants JimBobSquarePants deleted the bp/oldJpegCompression branch October 13, 2022 01:56
@JimBobSquarePants JimBobSquarePants mentioned this pull request Oct 13, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimBobSquarePants JimBobSquarePants JimBobSquarePants approved these changes

Assignees
No one assigned
Labels
formats:tiff
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brianpopow @JimBobSquarePants