Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle EOF in Jpeg bit reader when data is bad to prevent DOS attack.… #2523

Merged
merged 1 commit into from Aug 30, 2023
Merged

Handle EOF in Jpeg bit reader when data is bad to prevent DOS attack.… #2523

merged 1 commit into from Aug 30, 2023

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Cherry picked commit of #2516 so we can merge into main.

@JimBobSquarePants @antonfirsov
Handle EOF in Jpeg bit reader when data is bad to prevent DOS attack. (…
ed3860c 
…#2516)

* Handle EOF in bit reader when data is bad.

* Allow parallel processing of multi-megapixel image

* Stream seek can exceed the length of a stream

* Try triggering on release branches

* Update JpegBitReader.cs

* Skin on Win .NET 6

* All Win OS is an issue

* Address feedback

* add validation to CanIterateWithoutIntOverflow

---------

Co-authored-by: antonfirsov <antonfir@gmail.com>
@JimBobSquarePants JimBobSquarePants merged commit 9335a16 into main Aug 30, 2023
8 checks passed
@JimBobSquarePants JimBobSquarePants deleted the js/jpeg-eof-dos branch August 30, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonfirsov antonfirsov antonfirsov approved these changes

@tocsoft tocsoft Awaiting requested review from tocsoft

@dlemstra dlemstra Awaiting requested review from dlemstra

@brianpopow brianpopow Awaiting requested review from brianpopow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JimBobSquarePants @antonfirsov