Switch to Bottom as upper bound for Quantizer Rect #2549
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I was trying out Quantizer with custom rects. I couldn't get it to work and checked the code. To me it seems to be a typo where the
interest.Height
was used rather thaninterest.Bottom
. The x-dimensioninterest.Left
andinterest.Right
is used which makes sense to me.I did the change and it worked for me but then when I tried running the tests I got multiple image comparison failures.
So perhaps this is the intended behavior and I misunderstood the API. Or it is a good fix and oracles should be regenerated (but I don't know how).
I don't really know what is the right choice here so I thought I create a draft pull request even though the tests fails and you can tell me what do or just close it if it works as intended.
Regards,.