Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up on post-merge discussions in #2551 #2552

Merged
merged 1 commit into from Oct 14, 2023
Merged

Follow up on post-merge discussions in #2551 #2552

merged 1 commit into from Oct 14, 2023

Conversation

antonfirsov
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Minor tweaks for cleaner code.

@antonfirsov antonfirsov mentioned this pull request Oct 14, 2023
Merged
4 tasks
JimBobSquarePants
JimBobSquarePants approved these changes Oct 14, 2023
View reviewed changes
Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry about the confusion

@JimBobSquarePants JimBobSquarePants merged commit d93bc6c into main Oct 14, 2023
8 checks passed
@JimBobSquarePants JimBobSquarePants deleted the af/pbm-followup branch October 14, 2023 19:51
antonfirsov added a commit that referenced this pull request Oct 15, 2023
@antonfirsov
PBM decoder robustness improvements and BufferedReadStream observability
1f3aa0c 
Backport of #2551 & #2552
@antonfirsov antonfirsov mentioned this pull request Oct 15, 2023
Merged
JimBobSquarePants added a commit that referenced this pull request Oct 16, 2023
@antonfirsov @JimBobSquarePants
[release/2.1] PBM decoder robustness improvements and BufferedReadStr…
e74a55f 
…eam observability (#2555)

* PBM decoder robustness improvements and BufferedReadStream observability

Backport of #2551 & #2552

* Remove DoesNotReturn attribute

---------

Co-authored-by: James Jackson-South <james_south@hotmail.com>
@antonfirsov antonfirsov mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimBobSquarePants JimBobSquarePants JimBobSquarePants approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antonfirsov @JimBobSquarePants