Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling gif encoding for global palettes. #2614

Merged
merged 2 commits into from Dec 11, 2023
Merged

Fix handling gif encoding for global palettes. #2614

merged 2 commits into from Dec 11, 2023

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 馃懏.
  • I have provided test coverage for my change (where applicable)

Description

See SixLabors/ImageSharp.Web#344 (comment)

When an input gif has a full, non-transparent global palette we should use own to allow deduplication. Same image is reduced by 26% on encode.

@JimBobSquarePants JimBobSquarePants merged commit ad1b0e6 into release/3.1.x Dec 11, 2023
8 checks passed
@JimBobSquarePants JimBobSquarePants deleted the js/gif-global-256-no-trans-fix branch December 11, 2023 12:01
@JimBobSquarePants JimBobSquarePants restored the js/gif-global-256-no-trans-fix branch December 11, 2023 12:02
@JimBobSquarePants JimBobSquarePants mentioned this pull request Dec 11, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tocsoft tocsoft tocsoft approved these changes

@antonfirsov antonfirsov Awaiting requested review from antonfirsov

@dlemstra dlemstra Awaiting requested review from dlemstra

@brianpopow brianpopow Awaiting requested review from brianpopow

Assignees
No one assigned
Labels
bug formats:gif
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JimBobSquarePants @tocsoft