Replace Configuration.ParallelOptions with Configuration.MaxDegreeOfParallelism #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimBobSquarePants
approved these changes
Aug 5, 2018
| get => this.maxDegreeOfParallelism; | ||
| set | ||
| { | ||
| if (value <= 0) |
There was a problem hiding this comment.
Should this min value be 1?
There was a problem hiding this comment.
value <=0 means it has to be > 0
There was a problem hiding this comment.
Zero is an exclusive minimum here, if (value <= 1) would mean that we throw for MaxDegreeOfParallelism = 1 which is allowed!
There was a problem hiding this comment.
I'm pleading still jetlagged
Codecov Report
@@ Coverage Diff @@
## master #667 +/- ##
==========================================
- Coverage 89.79% 89.67% -0.13%
==========================================
Files 889 890 +1
Lines 37614 37633 +19
Branches 2468 2472 +4
==========================================
- Hits 33777 33747 -30
- Misses 3133 3182 +49
Partials 704 704
Continue to review full report at Codecov.
|
antonfirsov
added a commit
to antonfirsov/ImageSharp
that referenced
this pull request
Nov 11, 2019
Replace Configuration.ParallelOptions with Configuration.MaxDegreeOfParallelism
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fixes #651.
Internal helpers
ParallelFor.WithConfiguration(...)andParallelFor.WithTemporaryBuffer<T>(...)are utilized more heavily.