-
-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazily derive the huffman tables. Fix #839 #841
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor finding, otherwise everything looks good.
Codecov Report
@@ Coverage Diff @@
## master #841 +/- ##
==========================================
+ Coverage 88.87% 88.88% +<.01%
==========================================
Files 1015 1014 -1
Lines 44240 44272 +32
Branches 3202 3206 +4
==========================================
+ Hits 39319 39349 +30
- Misses 4200 4201 +1
- Partials 721 722 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on my current limited understanding, everything looks good.
I'm trusting our coverage more than my eyes now.
* Lazily derive the huffman tables. Fix SixLabors#839 * Lazy invoke fast table * Add performance tweaks to scan decoder. * Remove unneccessary classes.
Prerequisites
Description
libjpeg and co avoid bad remaining counts when reading the huffman table marker by leaving derivation until they reach the SOS segment and it's time to decode. We now do the same.