-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overkill damage #48
Overkill damage #48
Conversation
if it's in your scripts, imo, it should be in your devdeps
currently publicly visible at http://0350a0a5.ngrok.io/stats/4 |
Thanks. I will test this out tonight. |
The plan for the terminology now is I'm fine with keeping the faq page to explain those stats just in case. (I get ss vs logs damage questions very frequently) |
LGTM |
@SizzlingCalamari @forivall deployed |
Hmm, maybe the FAQ could be updated (in the short term) that server admins will need to update the sizzling stats plugin to see that they are different or, i could submit a pr to check the version and only display the tdpm / td columns if the plugin version is high enough. @SizzlingCalamari is the old version v0.1 and the new version v0.2? |
@forivall |
👍 |
fixes #47
Note the terminology change. A FAQ page has been added to explain the difference.
Some other minor changes were made, mainly in comments.
A full test, with a server running an up-to-date stats plugin, will be needed. ngrok works well for this; we should make a note of that. @dy-dx , did you use anything like it?