Skip to content

Overkill damage#48

Merged
SizzlingCalamari merged 5 commits into
SizzlingStats:masterfrom
forivall:overkill-damage
Sep 26, 2015
Merged

Overkill damage#48
SizzlingCalamari merged 5 commits into
SizzlingStats:masterfrom
forivall:overkill-damage

Conversation

@forivall
Copy link
Copy Markdown
Contributor

fixes #47

Note the terminology change. A FAQ page has been added to explain the difference.

Some other minor changes were made, mainly in comments.

A full test, with a server running an up-to-date stats plugin, will be needed. ngrok works well for this; we should make a note of that. @dy-dx , did you use anything like it?

@forivall
Copy link
Copy Markdown
Contributor Author

currently publicly visible at http://0350a0a5.ngrok.io/stats/4

@dy-dx
Copy link
Copy Markdown
Member

dy-dx commented Sep 24, 2015

Thanks. I will test this out tonight.

@SizzlingCalamari
Copy link
Copy Markdown
Member

The plan for the terminology now is
"RD" - "Real Damage"
"TD" - "Total Damage"
"RDPM" - "Real Damage Per Minute"
"TDPM" - "Total Damage Per Minute"

I'm fine with keeping the faq page to explain those stats just in case. (I get ss vs logs damage questions very frequently)

@SizzlingCalamari
Copy link
Copy Markdown
Member

LGTM

SizzlingCalamari added a commit that referenced this pull request Sep 26, 2015
@SizzlingCalamari SizzlingCalamari merged commit 29590cf into SizzlingStats:master Sep 26, 2015
@dy-dx
Copy link
Copy Markdown
Member

dy-dx commented Sep 26, 2015

@SizzlingCalamari @forivall deployed

@forivall
Copy link
Copy Markdown
Contributor Author

Hmm, maybe the FAQ could be updated (in the short term) that server admins will need to update the sizzling stats plugin to see that they are different

or, i could submit a pr to check the version and only display the tdpm / td columns if the plugin version is high enough. @SizzlingCalamari is the old version v0.1 and the new version v0.2?

@SizzlingCalamari
Copy link
Copy Markdown
Member

@forivall
We were just planning on doing a rollback until the plugin is ready, but adding the version number check sounds good to keep past stats looking the same. The current header version before this change is v0.2. I forgot to change the version when updating the json structure in the plugin, so v0.3 will be the version containing the overkill damage stat.

@forivall
Copy link
Copy Markdown
Contributor Author

👍

@forivall forivall deleted the overkill-damage branch October 5, 2015 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make use of "overkillDamage" stat on the web side

3 participants