Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TCHAR in mp3checker #23

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Use TCHAR in mp3checker #23

wants to merge 4 commits into from

Conversation

Sjord
Copy link
Owner

@Sjord Sjord commented Jun 8, 2017

To support unicode characters

@Sjord
Use TCHAR in mp3checker
8864836 
To support unicode characters
@Sjord
Copy link
Owner Author

Sjord commented Jun 8, 2017 •
edited

Todo:

  • Combo_AddDrives in rebar.c
  • Commented sprintf in mp3checker.c
  • fileerror in checkfile.c
  • error in checkarguments.c
  • merge declarations in checkarguments.h

@Sjord Sjord mentioned this pull request Jun 8, 2017
Open
Sjord added 3 commits June 8, 2017 16:20
@Sjord
Use consistent signature for recursive_check
d1587c9 
Even though TCHAR is just char ifndef WIN32
@Sjord
Use TCHAR correctly when adding drives
5594725
@Sjord
Remove commented code
e82ffda 
sprintf no longer works with TCHAR, and it was commented anyway
@Sjord
Copy link
Owner Author

Sjord commented Jun 13, 2017

I am getting convinced that using TCHAR is not the right way to approach this. Instead we should use UTF8 and only convert to UTF16 when calling Windows API functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Sjord