Improvements #58
Merged
Improvements #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w-i-n-s
force-pushed
the
fix_improvements
branch
from
657f79b
to
2bb627e
Compare
w-i-n-s
force-pushed
the
fix_improvements
branch
2 times, most recently
from
00c7529
to
852c117
Compare
Sjors
reviewed
Jun 28, 2021
| CodeScannerView(codeTypes: [.qr], completion: model.handleScan) | ||
| } | ||
| .alert(item: $model.scanQRError) { error in | ||
| Alert(title: Text("Import PSBT error"), |
There was a problem hiding this comment.
This title is wrong when scanning an address.
|
Not sure if this is related to this PR, but when I tap on the address it gets the strike-through. It should only happen if I tap on the check mark. Let's drop the "Address" header at the top, so "Scan to check" is at the top. It already says "Addresses" in the tab bar below, so it's redundant. |
I'll fix it in a separate PR, #62 |
w-i-n-s
force-pushed
the
fix_improvements
branch
from
ab1b861
to
debe292
Compare
w-i-n-s
force-pushed
the
fix_improvements
branch
from
debe292
to
7f6917e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next bulletpoins moved into another PR
Explain why sign button is disabled #30possible fixes
Crash when clicking Load PSBT #47[Feature] Add "Open with..." feature to import files directly from Specter/AirDrop #15