-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codebase review #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I create a wallet on master and then run this version, there seem to be two problems:
- in the settings screen the other cosigner is forgotten
- the addresses on the addresses screen are incorrect
Maybe something went wrong in the NSUserDefaults refactor commit 57f5af5?
|
Found another bug: the Show Mnemonic button no longer shows a popup. |
The show mnemonic button still doesn't work for me. Also don't forget to squash the |
Fixed by rollback d9c481f. Details in #14. On changing architecture to MVVM (according to #11) we also collect all possible errors/alerts and will use enumeration for displaying. Additional details about how it works: 3rd example and details |
Review the whole codebase and fix errors