Issue #7 Correction / If SHUTDOWN (WAKE pin) feature is not needed, the pin can be leave unconnected Issue #9 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If SHUTDOWN (WAKE pin) feature is not needed, the pin can be leave unconnected |
rtek1000
changed the title
rtek1000
changed the title
Skallwar
reviewed
Feb 29, 2024
| @@ -77,20 +90,14 @@ void GSL1680::clear_reg() | |||
| uint8_t DATA[4] = {0x88, 0x01, 0x04, 0x00}; | |||
| uint8_t TIMER[4] = {20, 5, 5, 20}; | |||
|
|
|||
| Wire.beginTransmission(I2CADDR); | |||
| uint8_t _data[1]; | |||
There was a problem hiding this comment.
Instead of an array of 1, just make it an uint8_t
|
|
||
| int i; | ||
| for (i = 0; i < 4; ++i) { | ||
| Wire.write(REG[i]); | ||
| Wire.write(DATA[i]); | ||
| delay(TIMER[i]); |
There was a problem hiding this comment.
No need for a delay here? I don't have the hardware anymore but I remember spending a lot of time figuring out the timings, it wouldn't work otherwise
| @@ -99,24 +106,19 @@ void GSL1680::reset() | |||
| uint8_t DATA[2] = {0x88, 0x04}; | |||
| uint8_t TIMER[2] = {20, 10}; | |||
|
|
|||
| Wire.beginTransmission(I2CADDR); | |||
| uint8_t _data[1]; | |||
|
|
||
| int i; | ||
| for (i = 0; i < 2; ++i) { | ||
| Wire.write(REG[i]); | ||
| Wire.write(DATA[i]); | ||
| delay(TIMER[i]); |
Comment on lines
+189
to
+196
| if(n == 5) { | ||
| SERIAL_ERROR.println("i2c write error: timeout"); | ||
| } else { | ||
| SERIAL_ERROR.print("i2c write error: "); | ||
| SERIAL_ERROR.print(n); | ||
| SERIAL_ERROR.print(" "); | ||
| SERIAL_ERROR.println(DATA_REG, HEX); | ||
| } |
There was a problem hiding this comment.
This block of code is in 2 places, could you make a function out of it?
README.md
Outdated
Comment on lines
16
to
17
| [Tested with ESP32 DEV KIT V1] | ||
|
|
There was a problem hiding this comment.
Suggested change
| [Tested with ESP32 DEV KIT V1] | |
| ## Test hardware | |
| - Arduino Mega 2560 Rev3 | |
| - ESP32 DEV KIT V1 | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7