This repository has been archived by the owner on Sep 29, 2022. It is now read-only.
Feature/aos 2839 helse endepunkt formater #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjartek
approved these changes
Oct 1, 2018
jarlehansen
suggested changes
Oct 1, 2018
| assertk.assert(response).isEqualTo( | ||
| HealthResponse( | ||
| HealthStatus.UP, | ||
| mutableMapOf( |
There was a problem hiding this comment.
Her syns jeg det hadde vært ryddig å enten dele opp koden eller ha med named arguments. For min del begynner dette å bli såpass mye kode på en gang at jeg sliter litt med å lese det.
There was a problem hiding this comment.
Bare noen småting, du kan velge om du vil ta det med eller ikke :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dere må gjerne komme tilbakemeldinger på om dere heller foretrekker første variant før jeg generaliserte koden. Fordeler og ulemper med begge. Lettere nå å se forskjellen på de to formatene, men enklere med den første å gjøre individuelle endringer om det er behov for det.