Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Working draft [fast&dirty] #1

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Working draft [fast&dirty] #1

merged 1 commit into from
Aug 27, 2020

Conversation

zhenik
Copy link
Contributor

@zhenik zhenik commented Aug 25, 2020 •
edited
Loading

I will do rebase, once get approved on this PR.

There are a bunch of TODOs.

Screenshot 2020-08-26 at 13 24 00

@zhenik zhenik self-assigned this Aug 25, 2020
@zhenik zhenik linked an issue Aug 25, 2020 that may be closed by this pull request
Working draft #2
Closed
@zhenik zhenik added this to the 0.0.1 - ALPHA milestone Aug 26, 2020
@zhenik zhenik marked this pull request as ready for review August 26, 2020 09:11
fredrikhgrelland
fredrikhgrelland reviewed Aug 26, 2020
View reviewed changes
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Vagrantfile Outdated Show resolved Hide resolved
format.sh Show resolved Hide resolved
Makefile Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
test_example/example/nomad_acl_test.tf Show resolved Hide resolved
test_example/main.tf Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
@zhenik
Copy link
Contributor Author

zhenik commented Aug 26, 2020 •
edited
Loading

@fredrikhgrelland FYI
Check https://github.com/fredrikhgrelland/terraform-nomad-hive/pull/1/checks?check_run_id=1031439299#step:8:379 is failing due to minio module. I have to remove provider "nomad" from main.tf there

@zhenik zhenik mentioned this pull request Aug 26, 2020
Closed
@zhenik
Copy link
Contributor Author

zhenik commented Aug 27, 2020 •
edited
Loading

Blocker Skatteetaten/terraform-nomad-minio#8

This was linked to issues Aug 27, 2020
Add data example upload #5
Closed
Add changelog #6
Closed
@zhenik zhenik removed a link to an issue Aug 27, 2020
Add data example upload #5
Closed
@fredrikhgrelland fredrikhgrelland merged commit 6424c91 into master Aug 27, 2020
@fredrikhgrelland fredrikhgrelland deleted the feature/zhenik-draft branch August 27, 2020 11:47
@zhenik zhenik mentioned this pull request Oct 27, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikhgrelland fredrikhgrelland fredrikhgrelland left review comments

Assignees

@zhenik zhenik

Labels
None yet
Projects
None yet
Milestone
0.0.1 - ALPHA
Development

Successfully merging this pull request may close these issues.

Add changelog Working draft
2 participants
@zhenik @fredrikhgrelland