Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper rendering of credentials #66

Closed
3 tasks done
dangernil opened this issue Oct 26, 2020 · 1 comment · Fixed by #69
Closed
3 tasks done

Proper rendering of credentials #66

dangernil opened this issue Oct 26, 2020 · 1 comment · Fixed by #69
Assignees
Milestone

Comments

@dangernil
Copy link
Contributor

dangernil commented Oct 26, 2020

Feature description

As a user of the module we want proper render of credentials, without using vault provider

Why is it needed?

To make it easier to use the module.

Suggestion(s)/solution(s) [Optional]

Done in Presto module: https://github.com/fredrikhgrelland/terraform-nomad-presto/blob/master/conf/nomad/presto.hcl#L327

Definition of done

  • Rendering credentials in .hcl file

Checklist (after created issue)

  • Added label(s)
  • Added to project
  • Added to milestone
@dangernil dangernil self-assigned this Oct 26, 2020
@dangernil dangernil added this to Priortized Backlog in Team DataStack via automation Oct 26, 2020
@dangernil dangernil added this to the 0.3.0 milestone Oct 26, 2020
@zhenik
Copy link
Contributor

zhenik commented Oct 27, 2020

@dangernil Wrong feature description -> As a user of the module we want proper render of credentials, without using vault provider

Take a look at #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants