Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for vault-provided credentials (and example) #64

Closed
3 tasks done
zhenik opened this issue Nov 2, 2020 · 5 comments · Fixed by #87
Closed
3 tasks done

Add support for vault-provided credentials (and example) #64

zhenik opened this issue Nov 2, 2020 · 5 comments · Fixed by #87
Assignees
Milestone

Comments

@zhenik
Copy link
Contributor

zhenik commented Nov 2, 2020

What is the issue?

Add support for fetching credentials for dependent modules from the Vault and render them directly to nomad job.

Suggestion(s)/solution(s) [Optional]

Follow hive pr Skatteetaten/terraform-nomad-hive#53

Optional

Creds with vault

Checklist (after created issue)

  • Added label(s)
  • Added to project
  • Added to milestone
@zhenik zhenik modified the milestone: 0.3.0 Nov 2, 2020
@zhenik zhenik self-assigned this Nov 6, 2020
@zhenik zhenik changed the title Add tests for vault-provided credentials Add support for vault-provided credentials (and example) Nov 11, 2020
@zhenik zhenik added this to the 0.3.0 milestone Nov 11, 2020
@zhenik zhenik mentioned this issue Nov 11, 2020
5 tasks
@claesgill
Copy link
Contributor

I'm not sure why we would want to do this. I mean examples of using Vault creds is present in all the modules already.

@zhenik
Copy link
Contributor Author

zhenik commented Nov 11, 2020

I'm not sure why we would want to do this. I mean examples of using Vault creds is present in all the modules already.

Supported:

  • Shared secret ref
  • minio secrets ref

Also, we might need to refactor variables.tf. There is typo with use_vault_secret_provider

variable "vault_secret" {
  type = object({
    use_vault_secret_provider = string,
    vault_kv_policy_name      = string,
    vault_kv_path             = string,
    vault_kv_secret_key_name  = string
  })
  description = "Set of properties to be able fetch shared cluster secret from vault"
  default = {
    use_vault_secret_provider = true
    vault_kv_policy_name      = "kv-secret"
    vault_kv_path             = "secret/data/presto"
    vault_kv_secret_key_name  = "cluster_shared_secret"
  }
}

@claesgill
Copy link
Contributor

Ahh got it, thought you meant something else. Then I agree, not sure about providing additional examples though. Should just use the ones we already have, and turning on every feature. WDYT?

It's late and I don't have my glasses, but I can't see any typos 😅 What's the typo?

@zhenik
Copy link
Contributor Author

zhenik commented Nov 11, 2020

Screenshot 2020-11-11 at 18 47 01

@claesgill
Copy link
Contributor

claesgill commented Nov 12, 2020

Oh, thanks! I fixed it (only the typo) in this PR #79

@zhenik zhenik linked a pull request Nov 12, 2020 that will close this issue
5 tasks
@zhenik zhenik removed a link to a pull request Nov 12, 2020
5 tasks
@zhenik zhenik modified the milestones: 0.3.0, 0.4.0 Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants