Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not restart when certificates are rolled. Presto will reload autom… #24

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Do not restart when certificates are rolled. Presto will reload autom… #24

merged 1 commit into from
Sep 24, 2020

Conversation

fredrikhgrelland
Copy link
Contributor

@fredrikhgrelland fredrikhgrelland self-assigned this Sep 21, 2020
pdmthorsrud
pdmthorsrud approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@pdmthorsrud pdmthorsrud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but why did you not remove the certificate-handler when you moved the handling of certificates over to the presto-server?

@fredrikhgrelland
Copy link
Contributor Author

LGTM, but why did you not remove the certificate-handler when you moved the handling of certificates over to the presto-server?

Uh.. I did?

@pdmthorsrud
Copy link
Contributor

LGTM, but why did you not remove the certificate-handler when you moved the handling of certificates over to the presto-server?

Uh.. I did?

You removed the certificate-handler in this PR, but you moved the handling of certificates in #19?

@fredrikhgrelland
Copy link
Contributor Author

True. That is an oversight.

@fredrikhgrelland fredrikhgrelland merged commit 80c0a50 into master Sep 24, 2020
@fredrikhgrelland fredrikhgrelland deleted the reload_certs branch September 24, 2020 07:07
@zhenik zhenik mentioned this pull request Sep 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdmthorsrud pdmthorsrud pdmthorsrud approved these changes

@zhenik zhenik Awaiting requested review from zhenik

Assignees

@fredrikhgrelland fredrikhgrelland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fredrikhgrelland @pdmthorsrud