Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to sync templated repo from upstream on a schedule #222

Closed
fredrikhgrelland opened this issue Aug 18, 2020 · 5 comments
Closed
Assignees
Labels
theme/ci Related to build, test, and release pipeline theme/template Related to vagrant-hashistack-template type/enhancement New feature or request wontfix This will not be worked on

Comments

@fredrikhgrelland
Copy link
Contributor

https://github.com/narrowspark/template-sync-action

@fredrikhgrelland fredrikhgrelland added type/enhancement New feature or request theme/template Related to vagrant-hashistack-template labels Aug 18, 2020
@fredrikhgrelland fredrikhgrelland self-assigned this Aug 18, 2020
@fredrikhgrelland fredrikhgrelland added the theme/ci Related to build, test, and release pipeline label Aug 18, 2020
@zhenik
Copy link
Contributor

zhenik commented Aug 24, 2020

Suggestion for each module that is created with the template:
1. rename branch master to upstream and leave it untouchable, only for sync with vagrant-hashistack-template
2. make new branch which is going to be the default branch

Once the original template is updated, the developer of the module decides the necessity of rebase upstream -> default

@zhenik
Copy link
Contributor

zhenik commented Sep 10, 2020

@fredrikhgrelland can you elaborate more why it should be done on schedule?

Update 1

I faced an issue and sync on schedule is one of the solutions.

Case:

  1. New linter v3.10.0 was released today
  2. Some of our current PR in modules start failing because of new linter checks.
  3. To be able continue we have to fix linter problems in original template
  4. Downstream patch changes from vagrant-hasistack to vagrant-hashistack-template
  5. Sync module with original-template

The current problem could be solved

  1. Use concrete linter version in original template instead of latest (bump periodically)
    https://github.com/fredrikhgrelland/vagrant-hashistack/blob/master/.github/workflows/on_pr_master.yml#L37
  2. Leave linter latest version schedule periodic sync vagrant-hasistack to vagrant-hashistack-template, and manual sync vagrant-hashistack-template -> module

@Neha-Sinha2305
Copy link
Contributor

I would go with Option 1:

Use concrete linter version in original template instead of latest (bump periodically)
https://github.com/fredrikhgrelland/vagrant-hashistack/blob/master/.github/workflows/on_pr_master.yml#L37

@fredrikhgrelland
Copy link
Contributor Author

Option 1 is always be the right one.

@fredrikhgrelland fredrikhgrelland added the type/question Further information is requested label Sep 11, 2020
@fredrikhgrelland fredrikhgrelland added wontfix This will not be worked on and removed type/question Further information is requested labels Sep 11, 2020
@fredrikhgrelland
Copy link
Contributor Author

This is irrelevant becuase of #331 closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ci Related to build, test, and release pipeline theme/template Related to vagrant-hashistack-template type/enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants