Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config merges in wrong sequence [Consul] #344

Closed
zhenik opened this issue Sep 21, 2020 · 0 comments · Fixed by #345
Closed

Config merges in wrong sequence [Consul] #344

zhenik opened this issue Sep 21, 2020 · 0 comments · Fixed by #345
Assignees
@zhenik
Labels
type/bug Something isn't working
Milestone
0.4.3

Comments

@zhenik
Copy link
Contributor

zhenik commented Sep 21, 2020 •
edited
Loading

Description

Consul daemon starts with the flag -dir-config. All available config files in directory will be merged into one config in lexical order.

When consul-acl switch enabled, there are will be two files config-acl.hcl and config.hcl.

Problem

Configuration merges first consul-acl.hcl then consul.hcl.

Right order:

  1. consul.hcl
  2. consul-acl.hcl

Todo

  • change config files names to make a lexical sequence explicit (like 0_config.hcl, 1_config-acl.hcl, etc...)
  • check the previous tests !!!
@zhenik zhenik added the type/bug Something isn't working label Sep 21, 2020
@zhenik zhenik added this to the 0.5.0 milestone Sep 21, 2020
@zhenik zhenik self-assigned this Sep 21, 2020
@zhenik zhenik modified the milestones: 0.5.0, 0.4.3 Sep 21, 2020
@zhenik zhenik linked a pull request Sep 21, 2020 that will close this issue
[Fix] Configuration files merge sequence #345
Merged
@zhenik zhenik added this to User stories in Team DataStack via automation Sep 21, 2020
@zhenik zhenik moved this from User stories to In progress in Team DataStack Sep 21, 2020
Team DataStack automation moved this from In progress to Done Sep 22, 2020
@Neha-Sinha2305 Neha-Sinha2305 moved this from Pull Requests merged and closed to QA in Team DataStack Sep 25, 2020
@Neha-Sinha2305 Neha-Sinha2305 mentioned this issue Sep 28, 2020
Open
This was referenced Sep 29, 2020
Closed
Closed
Closed
Open
Closed
@Neha-Sinha2305 Neha-Sinha2305 mentioned this issue Oct 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhenik zhenik

Labels
type/bug Something isn't working
Projects
None yet
Milestone
0.4.3
Development

Successfully merging a pull request may close this issue.

[Fix] Configuration files merge sequence Skatteetaten/vagrant-hashistack
1 participant
@zhenik