Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Configuration files merge sequence #345

Merged
merged 2 commits into from
Sep 22, 2020
Merged

[Fix] Configuration files merge sequence #345

merged 2 commits into from
Sep 22, 2020

Conversation

zhenik
Copy link
Contributor

@zhenik zhenik commented Sep 21, 2020

No description provided.

@zhenik zhenik added type/bug Something isn't working theme/test Related to testing theme/box labels Sep 21, 2020
@zhenik zhenik added this to the 0.4.3 milestone Sep 21, 2020
@zhenik zhenik self-assigned this Sep 21, 2020
@zhenik zhenik linked an issue Sep 21, 2020 that may be closed by this pull request
Config merges in wrong sequence [Consul] #344
Closed
@zhenik zhenik added this to In progress in Team DataStack via automation Sep 21, 2020
@zhenik zhenik moved this from In progress to Review in progress in Team DataStack Sep 21, 2020
@zhenik zhenik changed the title Fix/config merge seq [Fix] Configuration merge sequence Sep 21, 2020
@zhenik zhenik changed the title [Fix] Configuration merge sequence [Fix] Configuration files merge sequence Sep 21, 2020
pdmthorsrud
pdmthorsrud reviewed Sep 21, 2020
View reviewed changes
ansible/bootstrap.yml Outdated Show resolved Hide resolved
pdmthorsrud
pdmthorsrud previously approved these changes Sep 21, 2020
View reviewed changes
Team DataStack automation moved this from Review in progress to Reviewer approved Sep 21, 2020
Team DataStack automation moved this from Reviewer approved to Review in progress Sep 21, 2020
@zhenik zhenik mentioned this pull request Sep 22, 2020
Closed
pdmthorsrud
pdmthorsrud previously approved these changes Sep 22, 2020
View reviewed changes
Team DataStack automation moved this from Review in progress to Reviewer approved Sep 22, 2020
claesgill
claesgill previously approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@claesgill claesgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@zhenik zhenik dismissed stale reviews from claesgill and pdmthorsrud via 07d907b September 22, 2020 09:06
Team DataStack automation moved this from Reviewer approved to Review in progress Sep 22, 2020
Team DataStack automation moved this from Review in progress to Reviewer approved Sep 22, 2020
pdmthorsrud
pdmthorsrud approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@pdmthorsrud pdmthorsrud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fredrikhgrelland
fredrikhgrelland approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@fredrikhgrelland fredrikhgrelland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhenik zhenik merged commit 3c1c7eb into master Sep 22, 2020
Team DataStack automation moved this from Reviewer approved to Done Sep 22, 2020
@zhenik zhenik deleted the fix/config-merge-seq branch September 22, 2020 10:20
@fredrikhgrelland fredrikhgrelland removed this from Pull Requests merged and closed in Team DataStack Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikhgrelland fredrikhgrelland fredrikhgrelland approved these changes

@pdmthorsrud pdmthorsrud pdmthorsrud approved these changes

@claesgill claesgill claesgill left review comments

@dangernil dangernil Awaiting requested review from dangernil

Assignees

@zhenik zhenik

Labels
theme/box theme/test Related to testing type/bug Something isn't working
Projects
None yet
Milestone
0.4.3
Development

Successfully merging this pull request may close these issues.

Config merges in wrong sequence [Consul]
4 participants
@zhenik @claesgill @fredrikhgrelland @pdmthorsrud