Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vault PKI enabled #340

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Vault PKI enabled #340

merged 1 commit into from
Sep 22, 2020

Conversation

pdmthorsrud
Copy link
Contributor

@pdmthorsrud pdmthorsrud commented Sep 18, 2020 •
edited
Loading

closes #337

@pdmthorsrud pdmthorsrud marked this pull request as ready for review September 21, 2020 08:49
@pdmthorsrud
Copy link
Contributor Author

Do we need several roles that can issue certificates? I'm imagining what this PR does is allow us to at least test out the functionality of issuing certs

@pdmthorsrud pdmthorsrud mentioned this pull request Sep 21, 2020
Closed
@pdmthorsrud pdmthorsrud mentioned this pull request Sep 21, 2020
Merged
@zhenik zhenik added the type/documentation Improvements or additions to documentation label Sep 22, 2020
@zhenik zhenik added this to the 0.5.0 milestone Sep 22, 2020
zhenik
zhenik approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@zhenik zhenik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pdmthorsrud pdmthorsrud merged commit b6ecb5b into master Sep 22, 2020
@pdmthorsrud pdmthorsrud deleted the vault-pki branch September 22, 2020 08:44
@pdmthorsrud pdmthorsrud mentioned this pull request Sep 22, 2020
Closed
@pdmthorsrud pdmthorsrud restored the vault-pki branch September 28, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhenik zhenik zhenik approved these changes

@fredrikhgrelland fredrikhgrelland Awaiting requested review from fredrikhgrelland

Assignees

@pdmthorsrud pdmthorsrud

Labels
type/documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

Enable Vault PKI
2 participants
@pdmthorsrud @zhenik