Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Composer 2 compatibility #5

Merged
merged 1 commit into from Apr 16, 2022
Merged

Fixes Composer 2 compatibility #5

merged 1 commit into from Apr 16, 2022

Conversation

lindseydiloreto
Copy link
Contributor

This typo fix will solve the issue pointed out by Brandon in #2.

Closes #2

This typo fix will solve the issue pointed out by Brandon in #2.

Closes #2
@lindseydiloreto
Copy link
Contributor Author

It's worth noting that this PR does the inverse of what Brandon recommends... Instead of renaming the directory, we just corrected the namespace within the file itself. Looking at your other references to assetbundles, it seems that you always intended for cage to be lowercase in this context.

@jonasgeiler
Copy link
Member

Thanks! This was long overdue...

@jonasgeiler jonasgeiler merged commit 6660a3e into SkayoCrafts:master Apr 16, 2022
@lindseydiloreto lindseydiloreto deleted the patch-1 branch April 16, 2022 13:16
@lindseydiloreto
Copy link
Contributor Author

Awesome, thanks for rolling this in so quickly! Would you mind tagging an official release when you get a chance?

@lindseydiloreto
Copy link
Contributor Author

I see these changes in 1.1.0, thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Composer 2 compatibility
2 participants