fix: inefficient removeDuplicateImplied

SkepticMystic · Jul 15, 2021 · 3d2b88e · 3d2b88e
1 parent 10b64d4
commit 3d2b88e
Showing 1 changed file with 3 additions and 11 deletions.
diff --git a/src/MatrixView.ts b/src/MatrixView.ts
@@ -93,17 +93,9 @@ export default class MatrixView extends ItemView {
     reals: internalLinkObj[],
     implieds: internalLinkObj[]
   ): internalLinkObj[] {
-    // const noDuplicatesImplieds = implieds;
-    // reals.forEach(real => {
-    //   implieds.forEach((implied, i) => {
-    //     if (implied.to === real.to) {
-    //       noDuplicatesImplieds.slice(i, 1)
-    //     }
-    //   })
-    // });
-
-    const noDuplicates = implieds.filter(implied => !reals.map(real => real.to).includes(implied.to))
-    return noDuplicates
+
+    const realTos = reals.map(real => real.to);
+    return implieds.filter(implied => !realTos.includes(implied.to))
   }
 
   dfsAllPaths(g: Graph, startNode: string): string[][] {