Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

My sibling´s parent is my parent #301

Closed
scriptor-dga opened this issue Feb 1, 2022 · 7 comments
Closed

My sibling´s parent is my parent #301

scriptor-dga opened this issue Feb 1, 2022 · 7 comments

Comments

@scriptor-dga
Copy link

If A -up> B and C -same/next/prev> B, then C -implied down> A
SkepticMystic added a commit that referenced this issue Feb 5, 2022
@SkepticMystic
feat(impliedRelations): ✨ New optional impliedRelation: Siblings' par…
2a92f6d 
…ent is your parent (#301)
@SkepticMystic
Copy link
Owner

I've added this in the latest release, please let me know if it works :)

@ooker777
Copy link
Contributor

ooker777 commented Feb 5, 2022

If A -up> B and C -same/next/prev> B, then C -implied down> A

Isn't this aunt/uncle (parent's sibling) rather than sibling's parent? Also, is next/prev a specific kind of sibling?

@SkepticMystic
Copy link
Owner

Indeed. The relation described with the arrows is an Aunt/Uncle relation (already implemented). But the relation described in the title of the issue is different

@ooker777
Copy link
Contributor

ooker777 commented Feb 5, 2022

is next/prev a specific kind of sibling?

@SkepticMystic
Copy link
Owner

@ooker777 I guess so...
Next/Prev is just a directed sibling

@scriptor-dga
Copy link
Author

@ooker777 I guess so... Next/Prev is just a directed sibling

But they still don't show up as siblings...hence my FR here

@SkepticMystic
Copy link
Owner

Alright, I'm gonna close this issue because the initial request has been implemented, and the second request has its own FR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ooker777 @scriptor-dga @SkepticMystic