Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a test which identifies a broken algorithm #3

Closed
wants to merge 1 commit into from
Closed

add a test which identifies a broken algorithm #3

wants to merge 1 commit into from

Conversation

philihp
Copy link

@philihp philihp commented Feb 20, 2018

I believe your implementation does not work. Here is a test which identifies this.

     AssertionError: all of original elements should be included in output: expected
[ 'A', 'B', 'B', 'A', 'A', 'A', 'A' ] to be a superset of
[ 'A', 'B', 'C', 'D', 'E', 'F', 'G' ]

@SkepticalHippo
Copy link
Owner

Thanks for bringing this up. I'll look into it.

SkepticalHippo added a commit that referenced this pull request Mar 27, 2018
@SkepticalHippo
Copy link
Owner

Should be fixed in b4c2ca2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants