Refactoring and improve readability of Editor_Blocks #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push. |
thangngoc89
force-pushed
the
clean-blocks
branch
from
40567f7
to
0562035
Compare
And make it an instance variable
matthiaskern
added a commit
that referenced
this pull request
Sep 4, 2018
commit 2c89306 Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 03:51:31 2018 +0700 temporary fix this thing :D commit 46638e6 Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 03:45:17 2018 +0700 More stuff commit 4a907a9 Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 03:39:41 2018 +0700 npm. STOP update package-lock on install!!! commit 927b61e Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 03:32:13 2018 +0700 Fix test commit d450bf6 Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 03:30:49 2018 +0700 Add cypress test commit 359ef38 Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 03:10:48 2018 +0700 Comment out state reset in executeMany commit f78546c Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 03:08:22 2018 +0700 More rebase commit 7100799 Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 02:59:07 2018 +0700 Done rebase commit 75a05b2 Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 02:53:31 2018 +0700 Put back Editor_Note commit 35b56af Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 02:53:03 2018 +0700 Put back Editor_Note commit 752c376 Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 02:49:03 2018 +0700 Finish rebase commit 77e37fd Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Sep 4 20:34:25 2018 +0200 fix its commit 2c41242 Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Sep 4 17:51:23 2018 +0200 notify of link errors commit 5eb2740 Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Sep 4 15:53:41 2018 +0200 readd saving commit 4283343 Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Sep 4 15:25:28 2018 +0200 update toplevel.js commit 0068aa2 Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Sep 4 15:18:47 2018 +0200 readd toplevel link commit a4b437e Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Sep 4 10:33:01 2018 +0200 readd links menu commit f1721d0 Author: Matthias Kern <matthias_kern@posteo.net> Date: Mon Sep 3 16:21:26 2018 +0200 readd links ui commit 1faa794 Author: Matthias Kern <matthias_kern@posteo.net> Date: Mon Sep 3 16:08:54 2018 +0200 remove file commit 5dc8c72 Author: Matthias Kern <matthias_kern@posteo.net> Date: Mon Sep 3 15:38:57 2018 +0200 update toplevel binding commit b885867 Author: Matthias Kern <matthias_kern@posteo.net> Date: Mon Sep 3 14:53:44 2018 +0200 fix links after merge commit 2927727 Author: Matthias Kern <matthias_kern@posteo.net> Date: Mon Sep 3 14:32:45 2018 +0200 checkout files commit ee5b49b Author: Matthias Kern <matthias_kern@posteo.net> Date: Mon Sep 3 12:00:44 2018 +0200 update to bs-json v3 commit e6d8427 Author: Matthias Kern <matthias_kern@posteo.net> Date: Mon Sep 3 12:00:34 2018 +0200 use new toplevel build commit ee49290 Author: Matthias Kern <matthias_kern@posteo.net> Date: Sun Sep 2 09:59:20 2018 +0300 progress commit bf88d93 Author: Matthias Kern <matthias_kern@posteo.net> Date: Thu Aug 30 20:05:25 2018 +0300 add onDelete commit 8bbf130 Author: Matthias Kern <matthias_kern@posteo.net> Date: Thu Aug 30 19:42:00 2018 +0300 update toplevel, finalize bindings commit c389638 Author: Matthias Kern <matthias_kern@posteo.net> Date: Wed Aug 29 10:08:54 2018 +0300 add links menu and styles commit 7e25b78 Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Aug 28 21:41:17 2018 +0300 new link format commit f393b65 Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Aug 28 20:42:48 2018 +0300 fix rebase commit 6145cc4 Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Aug 28 12:54:35 2018 +0300 progress commit 308c8ae Author: Khoa Nguyen <thangngoc89@users.noreply.github.com> Date: Wed Sep 5 01:14:04 2018 +0700 client: refactor prevent route transition (#173) * Switch to a callback based approach * It's working * Done refactoring * Refactoring into getUnloadMessage * Add Router.rei * Update comments commit 1b909df Author: Khoa Nguyen <thangngoc89@users.noreply.github.com> Date: Wed Sep 5 00:08:57 2018 +0700 chore: Refactoring and improve readability of Editor_Blocks (#170) * Clean up delete blocks state * More clean up * More refactoring * Move pretty print out * Move reducer body to functions * Add comments * Add square logo * Add queued delete timeout to `onUnmount` * Separate block_add and add test to make sure newly create block has focus * Move all actions to function * Add tips * Refactoring deletedBlockMeta into a map And make it an instance variable * Remove newBlock. This make 2 blocks have the same id. Really bad :( * Fix interface * Acknowledge about automatically create new empty code block when deleted all blocks * Change save and fork notify to success * Extract prettyPrint and changeLanguage common parts commit 2379919 Author: Khoa Nguyen <thangngoc89@users.noreply.github.com> Date: Tue Sep 4 22:20:24 2018 +0700 Less distracting delete animation (#165) * Less distracting animation * Improve delete animation * Update Editor_Blocks.re commit 82a740e Author: Peter Weinberg <pweinberg633@gmail.com> Date: Tue Sep 4 07:22:39 2018 -0400 fix: config toggle comment keybindings and autoCloseBrackets (#167) * fix: allow cmd+/ on mac to toggle comments * add auto close brackets codemirror functionality commit 0379ab7 Author: Khoa Nguyen <thangngoc89@users.noreply.github.com> Date: Tue Sep 4 17:36:16 2018 +0700 fix: Refmt restore deleted block when called (#169) commit 0cffa4d Author: Khoa Nguyen <hi@khoanguyen.me> Date: Mon Sep 3 21:36:37 2018 +0700 chore: Add a CHANGELOG commit af01cb4 Author: Khoa Nguyen <hi@khoanguyen.me> Date: Mon Sep 3 21:33:19 2018 +0700 fix: language_toggle test
matthiaskern
added a commit
that referenced
this pull request
Sep 4, 2018
commit 4e57fe4 Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 03:51:31 2018 +0700 temporary fix this thing :D commit 1d743ed Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 03:45:17 2018 +0700 More stuff commit e5b20de Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 03:39:41 2018 +0700 npm. STOP update package-lock on install!!! commit 51482e2 Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 03:32:13 2018 +0700 Fix test commit 43bfe6b Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 03:30:49 2018 +0700 Add cypress test commit 17ff08c Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 03:10:48 2018 +0700 Comment out state reset in executeMany commit ca5da4a Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 03:08:22 2018 +0700 More rebase commit 858147c Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 02:59:07 2018 +0700 Done rebase commit 4824d0d Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 02:53:31 2018 +0700 Put back Editor_Note commit 069f746 Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 02:53:03 2018 +0700 Put back Editor_Note commit 1be204b Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 02:49:03 2018 +0700 Finish rebase commit a35efdc Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Sep 4 20:34:25 2018 +0200 fix its commit 520b4a2 Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Sep 4 17:51:23 2018 +0200 notify of link errors commit e66aab1 Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Sep 4 15:53:41 2018 +0200 readd saving commit 9819a5b Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Sep 4 15:25:28 2018 +0200 update toplevel.js commit 3b44b43 Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Sep 4 15:18:47 2018 +0200 readd toplevel link commit a87f8ed Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Sep 4 10:33:01 2018 +0200 readd links menu commit 6101ad1 Author: Matthias Kern <matthias_kern@posteo.net> Date: Mon Sep 3 16:21:26 2018 +0200 readd links ui commit 4fa828e Author: Matthias Kern <matthias_kern@posteo.net> Date: Mon Sep 3 16:08:54 2018 +0200 remove file commit 36c09ec Author: Matthias Kern <matthias_kern@posteo.net> Date: Mon Sep 3 15:38:57 2018 +0200 update toplevel binding commit 4c32d92 Author: Matthias Kern <matthias_kern@posteo.net> Date: Mon Sep 3 14:53:44 2018 +0200 fix links after merge commit fd19517 Author: Matthias Kern <matthias_kern@posteo.net> Date: Mon Sep 3 14:32:45 2018 +0200 checkout files commit ea98b57 Author: Matthias Kern <matthias_kern@posteo.net> Date: Mon Sep 3 12:00:44 2018 +0200 update to bs-json v3 commit e08a524 Author: Matthias Kern <matthias_kern@posteo.net> Date: Mon Sep 3 12:00:34 2018 +0200 use new toplevel build commit f43a466 Author: Matthias Kern <matthias_kern@posteo.net> Date: Sun Sep 2 09:59:20 2018 +0300 progress commit ca6ad1f Author: Matthias Kern <matthias_kern@posteo.net> Date: Thu Aug 30 20:05:25 2018 +0300 add onDelete commit 25fc71b Author: Matthias Kern <matthias_kern@posteo.net> Date: Thu Aug 30 19:42:00 2018 +0300 update toplevel, finalize bindings commit bfaec94 Author: Matthias Kern <matthias_kern@posteo.net> Date: Wed Aug 29 10:08:54 2018 +0300 add links menu and styles commit 901e959 Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Aug 28 21:41:17 2018 +0300 new link format commit 6ae3b5a Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Aug 28 20:42:48 2018 +0300 fix rebase commit 93c4779 Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Aug 28 12:54:35 2018 +0300 progress commit 7a4f802 Author: Khoa Nguyen <thangngoc89@users.noreply.github.com> Date: Wed Sep 5 04:12:41 2018 +0700 refactor: Use key instead of willReceiveProps (#175) commit 308c8ae Author: Khoa Nguyen <thangngoc89@users.noreply.github.com> Date: Wed Sep 5 01:14:04 2018 +0700 client: refactor prevent route transition (#173) * Switch to a callback based approach * It's working * Done refactoring * Refactoring into getUnloadMessage * Add Router.rei * Update comments commit 1b909df Author: Khoa Nguyen <thangngoc89@users.noreply.github.com> Date: Wed Sep 5 00:08:57 2018 +0700 chore: Refactoring and improve readability of Editor_Blocks (#170) * Clean up delete blocks state * More clean up * More refactoring * Move pretty print out * Move reducer body to functions * Add comments * Add square logo * Add queued delete timeout to `onUnmount` * Separate block_add and add test to make sure newly create block has focus * Move all actions to function * Add tips * Refactoring deletedBlockMeta into a map And make it an instance variable * Remove newBlock. This make 2 blocks have the same id. Really bad :( * Fix interface * Acknowledge about automatically create new empty code block when deleted all blocks * Change save and fork notify to success * Extract prettyPrint and changeLanguage common parts commit 2379919 Author: Khoa Nguyen <thangngoc89@users.noreply.github.com> Date: Tue Sep 4 22:20:24 2018 +0700 Less distracting delete animation (#165) * Less distracting animation * Improve delete animation * Update Editor_Blocks.re commit 82a740e Author: Peter Weinberg <pweinberg633@gmail.com> Date: Tue Sep 4 07:22:39 2018 -0400 fix: config toggle comment keybindings and autoCloseBrackets (#167) * fix: allow cmd+/ on mac to toggle comments * add auto close brackets codemirror functionality commit 0379ab7 Author: Khoa Nguyen <thangngoc89@users.noreply.github.com> Date: Tue Sep 4 17:36:16 2018 +0700 fix: Refmt restore deleted block when called (#169) commit 0cffa4d Author: Khoa Nguyen <hi@khoanguyen.me> Date: Mon Sep 3 21:36:37 2018 +0700 chore: Add a CHANGELOG commit af01cb4 Author: Khoa Nguyen <hi@khoanguyen.me> Date: Mon Sep 3 21:33:19 2018 +0700 fix: language_toggle test
matthiaskern
added a commit
that referenced
this pull request
Sep 4, 2018
commit 4e57fe4 Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 03:51:31 2018 +0700 temporary fix this thing :D commit 1d743ed Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 03:45:17 2018 +0700 More stuff commit e5b20de Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 03:39:41 2018 +0700 npm. STOP update package-lock on install!!! commit 51482e2 Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 03:32:13 2018 +0700 Fix test commit 43bfe6b Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 03:30:49 2018 +0700 Add cypress test commit 17ff08c Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 03:10:48 2018 +0700 Comment out state reset in executeMany commit ca5da4a Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 03:08:22 2018 +0700 More rebase commit 858147c Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 02:59:07 2018 +0700 Done rebase commit 4824d0d Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 02:53:31 2018 +0700 Put back Editor_Note commit 069f746 Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 02:53:03 2018 +0700 Put back Editor_Note commit 1be204b Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 02:49:03 2018 +0700 Finish rebase commit a35efdc Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Sep 4 20:34:25 2018 +0200 fix its commit 520b4a2 Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Sep 4 17:51:23 2018 +0200 notify of link errors commit e66aab1 Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Sep 4 15:53:41 2018 +0200 readd saving commit 9819a5b Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Sep 4 15:25:28 2018 +0200 update toplevel.js commit 3b44b43 Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Sep 4 15:18:47 2018 +0200 readd toplevel link commit a87f8ed Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Sep 4 10:33:01 2018 +0200 readd links menu commit 6101ad1 Author: Matthias Kern <matthias_kern@posteo.net> Date: Mon Sep 3 16:21:26 2018 +0200 readd links ui commit 4fa828e Author: Matthias Kern <matthias_kern@posteo.net> Date: Mon Sep 3 16:08:54 2018 +0200 remove file commit 36c09ec Author: Matthias Kern <matthias_kern@posteo.net> Date: Mon Sep 3 15:38:57 2018 +0200 update toplevel binding commit 4c32d92 Author: Matthias Kern <matthias_kern@posteo.net> Date: Mon Sep 3 14:53:44 2018 +0200 fix links after merge commit fd19517 Author: Matthias Kern <matthias_kern@posteo.net> Date: Mon Sep 3 14:32:45 2018 +0200 checkout files commit ea98b57 Author: Matthias Kern <matthias_kern@posteo.net> Date: Mon Sep 3 12:00:44 2018 +0200 update to bs-json v3 commit e08a524 Author: Matthias Kern <matthias_kern@posteo.net> Date: Mon Sep 3 12:00:34 2018 +0200 use new toplevel build commit f43a466 Author: Matthias Kern <matthias_kern@posteo.net> Date: Sun Sep 2 09:59:20 2018 +0300 progress commit ca6ad1f Author: Matthias Kern <matthias_kern@posteo.net> Date: Thu Aug 30 20:05:25 2018 +0300 add onDelete commit 25fc71b Author: Matthias Kern <matthias_kern@posteo.net> Date: Thu Aug 30 19:42:00 2018 +0300 update toplevel, finalize bindings commit bfaec94 Author: Matthias Kern <matthias_kern@posteo.net> Date: Wed Aug 29 10:08:54 2018 +0300 add links menu and styles commit 901e959 Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Aug 28 21:41:17 2018 +0300 new link format commit 6ae3b5a Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Aug 28 20:42:48 2018 +0300 fix rebase commit 93c4779 Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Aug 28 12:54:35 2018 +0300 progress commit 7a4f802 Author: Khoa Nguyen <thangngoc89@users.noreply.github.com> Date: Wed Sep 5 04:12:41 2018 +0700 refactor: Use key instead of willReceiveProps (#175) commit 308c8ae Author: Khoa Nguyen <thangngoc89@users.noreply.github.com> Date: Wed Sep 5 01:14:04 2018 +0700 client: refactor prevent route transition (#173) * Switch to a callback based approach * It's working * Done refactoring * Refactoring into getUnloadMessage * Add Router.rei * Update comments commit 1b909df Author: Khoa Nguyen <thangngoc89@users.noreply.github.com> Date: Wed Sep 5 00:08:57 2018 +0700 chore: Refactoring and improve readability of Editor_Blocks (#170) * Clean up delete blocks state * More clean up * More refactoring * Move pretty print out * Move reducer body to functions * Add comments * Add square logo * Add queued delete timeout to `onUnmount` * Separate block_add and add test to make sure newly create block has focus * Move all actions to function * Add tips * Refactoring deletedBlockMeta into a map And make it an instance variable * Remove newBlock. This make 2 blocks have the same id. Really bad :( * Fix interface * Acknowledge about automatically create new empty code block when deleted all blocks * Change save and fork notify to success * Extract prettyPrint and changeLanguage common parts commit 2379919 Author: Khoa Nguyen <thangngoc89@users.noreply.github.com> Date: Tue Sep 4 22:20:24 2018 +0700 Less distracting delete animation (#165) * Less distracting animation * Improve delete animation * Update Editor_Blocks.re commit 82a740e Author: Peter Weinberg <pweinberg633@gmail.com> Date: Tue Sep 4 07:22:39 2018 -0400 fix: config toggle comment keybindings and autoCloseBrackets (#167) * fix: allow cmd+/ on mac to toggle comments * add auto close brackets codemirror functionality commit 0379ab7 Author: Khoa Nguyen <thangngoc89@users.noreply.github.com> Date: Tue Sep 4 17:36:16 2018 +0700 fix: Refmt restore deleted block when called (#169) commit 0cffa4d Author: Khoa Nguyen <hi@khoanguyen.me> Date: Mon Sep 3 21:36:37 2018 +0700 chore: Add a CHANGELOG commit af01cb4 Author: Khoa Nguyen <hi@khoanguyen.me> Date: Mon Sep 3 21:33:19 2018 +0700 fix: language_toggle test
matthiaskern
added a commit
that referenced
this pull request
Sep 16, 2018
* progress * fix rebase * new link format * add links menu and styles * update toplevel, finalize bindings * add onDelete * progress * use new toplevel build * update to bs-json v3 * checkout files * fix links after merge * update toplevel binding * remove file * readd links ui * readd links menu * readd toplevel link * update toplevel.js * readd saving * notify of link errors * improve error messages * fix its * Delete old worker interface * Rebase on master fix links state handling commit 4e57fe4 Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 03:51:31 2018 +0700 temporary fix this thing :D commit 1d743ed Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 03:45:17 2018 +0700 More stuff commit e5b20de Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 03:39:41 2018 +0700 npm. STOP update package-lock on install!!! commit 51482e2 Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 03:32:13 2018 +0700 Fix test commit 43bfe6b Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 03:30:49 2018 +0700 Add cypress test commit 17ff08c Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 03:10:48 2018 +0700 Comment out state reset in executeMany commit ca5da4a Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 03:08:22 2018 +0700 More rebase commit 858147c Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 02:59:07 2018 +0700 Done rebase commit 4824d0d Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 02:53:31 2018 +0700 Put back Editor_Note commit 069f746 Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 02:53:03 2018 +0700 Put back Editor_Note commit 1be204b Author: Khoa Nguyen <hi@khoanguyen.me> Date: Wed Sep 5 02:49:03 2018 +0700 Finish rebase commit a35efdc Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Sep 4 20:34:25 2018 +0200 fix its commit 520b4a2 Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Sep 4 17:51:23 2018 +0200 notify of link errors commit e66aab1 Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Sep 4 15:53:41 2018 +0200 readd saving commit 9819a5b Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Sep 4 15:25:28 2018 +0200 update toplevel.js commit 3b44b43 Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Sep 4 15:18:47 2018 +0200 readd toplevel link commit a87f8ed Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Sep 4 10:33:01 2018 +0200 readd links menu commit 6101ad1 Author: Matthias Kern <matthias_kern@posteo.net> Date: Mon Sep 3 16:21:26 2018 +0200 readd links ui commit 4fa828e Author: Matthias Kern <matthias_kern@posteo.net> Date: Mon Sep 3 16:08:54 2018 +0200 remove file commit 36c09ec Author: Matthias Kern <matthias_kern@posteo.net> Date: Mon Sep 3 15:38:57 2018 +0200 update toplevel binding commit 4c32d92 Author: Matthias Kern <matthias_kern@posteo.net> Date: Mon Sep 3 14:53:44 2018 +0200 fix links after merge commit fd19517 Author: Matthias Kern <matthias_kern@posteo.net> Date: Mon Sep 3 14:32:45 2018 +0200 checkout files commit ea98b57 Author: Matthias Kern <matthias_kern@posteo.net> Date: Mon Sep 3 12:00:44 2018 +0200 update to bs-json v3 commit e08a524 Author: Matthias Kern <matthias_kern@posteo.net> Date: Mon Sep 3 12:00:34 2018 +0200 use new toplevel build commit f43a466 Author: Matthias Kern <matthias_kern@posteo.net> Date: Sun Sep 2 09:59:20 2018 +0300 progress commit ca6ad1f Author: Matthias Kern <matthias_kern@posteo.net> Date: Thu Aug 30 20:05:25 2018 +0300 add onDelete commit 25fc71b Author: Matthias Kern <matthias_kern@posteo.net> Date: Thu Aug 30 19:42:00 2018 +0300 update toplevel, finalize bindings commit bfaec94 Author: Matthias Kern <matthias_kern@posteo.net> Date: Wed Aug 29 10:08:54 2018 +0300 add links menu and styles commit 901e959 Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Aug 28 21:41:17 2018 +0300 new link format commit 6ae3b5a Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Aug 28 20:42:48 2018 +0300 fix rebase commit 93c4779 Author: Matthias Kern <matthias_kern@posteo.net> Date: Tue Aug 28 12:54:35 2018 +0300 progress commit 7a4f802 Author: Khoa Nguyen <thangngoc89@users.noreply.github.com> Date: Wed Sep 5 04:12:41 2018 +0700 refactor: Use key instead of willReceiveProps (#175) commit 308c8ae Author: Khoa Nguyen <thangngoc89@users.noreply.github.com> Date: Wed Sep 5 01:14:04 2018 +0700 client: refactor prevent route transition (#173) * Switch to a callback based approach * It's working * Done refactoring * Refactoring into getUnloadMessage * Add Router.rei * Update comments commit 1b909df Author: Khoa Nguyen <thangngoc89@users.noreply.github.com> Date: Wed Sep 5 00:08:57 2018 +0700 chore: Refactoring and improve readability of Editor_Blocks (#170) * Clean up delete blocks state * More clean up * More refactoring * Move pretty print out * Move reducer body to functions * Add comments * Add square logo * Add queued delete timeout to `onUnmount` * Separate block_add and add test to make sure newly create block has focus * Move all actions to function * Add tips * Refactoring deletedBlockMeta into a map And make it an instance variable * Remove newBlock. This make 2 blocks have the same id. Really bad :( * Fix interface * Acknowledge about automatically create new empty code block when deleted all blocks * Change save and fork notify to success * Extract prettyPrint and changeLanguage common parts commit 2379919 Author: Khoa Nguyen <thangngoc89@users.noreply.github.com> Date: Tue Sep 4 22:20:24 2018 +0700 Less distracting delete animation (#165) * Less distracting animation * Improve delete animation * Update Editor_Blocks.re commit 82a740e Author: Peter Weinberg <pweinberg633@gmail.com> Date: Tue Sep 4 07:22:39 2018 -0400 fix: config toggle comment keybindings and autoCloseBrackets (#167) * fix: allow cmd+/ on mac to toggle comments * add auto close brackets codemirror functionality commit 0379ab7 Author: Khoa Nguyen <thangngoc89@users.noreply.github.com> Date: Tue Sep 4 17:36:16 2018 +0700 fix: Refmt restore deleted block when called (#169) commit 0cffa4d Author: Khoa Nguyen <hi@khoanguyen.me> Date: Mon Sep 3 21:36:37 2018 +0700 chore: Add a CHANGELOG commit af01cb4 Author: Khoa Nguyen <hi@khoanguyen.me> Date: Mon Sep 3 21:33:19 2018 +0700 fix: language_toggle test * fix typo * change alignment of link menu * add link timestamp * remove stub handling for external Links * some comments * add error message when link is not found * retry for failed links * Execute link after fetching * some error handling * cancel for link * use single toplevel execute function * only reset inside linkMany * improve worker formatting * refactor worker types * don't stop linking when one fails * remove unused exception * render existing links as router links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm moving each reducer handler into it own function. There are no performance hits because Bucklescript inlines the functions body directly to reducer sections when you add an interface and hide the functions
I also added a tons of comments on each functions.
cc @matthiaskern @no-stack-dub-sack