Evaluate all code blocks below current block with same scope #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thangngoc89
reviewed
Jul 31, 2018
| @@ -10,7 +10,7 @@ let renderErrorIndicator = (colStart, colEnd, content) => | |||
| ++ "\n" | |||
| ++ content; | |||
|
|
|||
| let executeRessultToWidget = (result: list(Worker_Types.blockData)) => { | |||
| let executeResultToWidget = (result: list(Worker_Types.blockData)) => { | |||
There was a problem hiding this comment.
I blame @-jaredly for this. His reason-language-server is so good that I just tab tab tab
matthiaskern
force-pushed
the
connected-fields
branch
from
2203c03
to
e0033cd
Compare
thangngoc89
reviewed
Jul 31, 2018
|
|
||
| let executeMany: | ||
| Belt.Map.String.t(string) => Belt.Map.String.t(list(blockData)) = | ||
| codeMap => { |
There was a problem hiding this comment.
This should be an explicit uncurried function. Bucklescript and ES6 proxy doesn't play nice with each others.
(. codeMap) =>
thangngoc89
requested changes
Jul 31, 2018
client/src_editor/Editor_Blocks.re
Outdated
| ) | ||
| } | ||
| }; | ||
| | Block_Execute(_blockId) => |
There was a problem hiding this comment.
If we are not using it then we better remove _blockId completely
client/src_editor/Editor_Blocks.re
Outdated
| | Block_Execute(_blockId) => | ||
| let allCodeBlocks = | ||
| Belt.Map.String.fromArray( | ||
| state.blocks |
There was a problem hiding this comment.
This is really inefficient (3n). We can do this in a single loop like this:
module MS = Belt.Map.String;
state.blocks
|. Belt.Array.reduceU(MS.empty, (. map, {b_id, b_data}) => {
switch (b_data) {
| B_Text(_) => map
| B_Code({bc_value}) => map |. MS.set(b_id, bc_value)
}
}))As always, I didn't test this code :D
matthiaskern
force-pushed
the
connected-fields
branch
from
e0033cd
to
bff517a
Compare
thangngoc89
reviewed
Jul 31, 2018
| | B_Text(_) => map | ||
| | B_Code({bc_value}) => map |. MS.set(b_id, bc_value) | ||
| } | ||
| ); |
There was a problem hiding this comment.
Whaaaaaaat. This really works huh?
There was a problem hiding this comment.
It actually does! 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally I think clearing up widgets in lower blocks should be cleared when the current field is updated.