New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing load errors on systems where multi-byte characters are present… #154
Comments
This is with the latest version, 2.1.4? |
same error here. I am using Windows 10 (Chinese), latest SketchUp and latest sketchup-stl plugin. The installation was "successful", but when I restart sketchUp, this error message popped up. The export stl option never shows up in the drop-down menu. (Although I know nothing about Ruby, I am wondering if sketchup is trying to downcase a non-English character. You can downcase "É" to "é" but one does not simply downcase "박민규" or "守建" :)
for the moment, I will create a new user account to try this plugin out. |
Edited - See next comment. |
Oops, here is the correct link: https://github.com/jimfoltz/sketchup-stl/releases/tag/v2.1.5-154.1 |
Thank you for the lightning-fast reply. I tried your plugin but it seems the problem persists. The error message is as follow:
(I deleted the old sketchup-stl.rb and the sketchup-stl folder before installing your version.) |
Jim, the problem looks to be the string sent to file_loaded? On Sun, Oct 4, 2015, 12:16 Sam-C notifications@github.com wrote:
|
ohh, I forgot to mention that I created a new user account called "visitor" and installed the old plug-in there. The path was |
In a language other than English, it will not be able to run the STL PLUGIN. |
@duveen and @Sam-C - can you download the RBZ from this page (https://github.com/thomthom/sketchup-stl/releases/tag/fix-unicode-username) and test if that solves the load errors? (If there are still errors - please post them back here.) |
I am beginning to wonder if there is a purpose to using |
There is a point to prevent UI and importers/exporters as well as But the issue here is bugs in Ruby itself - where https://bugs.ruby-lang.org/issues/9713#change-46121 That being said - until the Ruby core fixes this you probably want to avoid |
Under what circumstances would |
While developing you often need to reload files. But also other than that you might risk your files being loaded more than once due to differences of how |
I installed from https://github.com/thomthom/sketchup-stl/releases/tag/fix-unicode-username and it fixed the loading error. 😄 It now loads without any error code. The ".stl" option from "Import..." and the "Export STL..." option correctly appears. |
Thanks for testing. I'll create a pull-request to have that fix included and make a new release. |
Does SKUI core.rb have a similar issue using |
Looking over the SKUI code it doesn't look to be the case. It fetches |
To be honest, I am not certain using 'self.name' is the best way. For one, the name of the method is _file__loaded indicating it is expecting a file. In some extensions I have been using 'if not defined?(ModuleName::PluginName)' at the top of the file to wrap menu creation inside. |
It doesn't matter too much - as long as the string you pass is unique for the load guard you are creating. You could use a GUID if you want. |
I am Korean and are not good at English. Please understand.
This error was fixed #134 from. But, Korean language in the same error occurs.
Up to date, and rb a result of the latest issue been applied to load the file. Fix please
The text was updated successfully, but these errors were encountered: