Flp 606 Add standards and standard versions info to start date query to enable validation #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Apprenticeships/SFA.DAS.Apprenticeships.UnitTests/Application/Apprenticeship/WhenGettingApprenticeshipStartDate.cs # src/Apprenticeships/SFA.DAS.Apprenticeships/Application/Apprenticeship/GetApprenticeshipStartDateQuery.cs # src/Apprenticeships/SFA.DAS.Apprenticeships/Responses/ApprenticeshipStartDateResponse.cs # src/Shared/SFA.DAS.SharedOuterApi/InnerApi/Responses/Apprenticeships/GetApprenticeshipStartDateResponse.cs
…tandardInfo (e.g. if there is a standard version with no effective to date it is open and so any date after the effective from is valid
dinathain
reviewed
Apr 19, 2024
...eships/SFA.DAS.Apprenticeships/Application/Apprenticeship/GetApprenticeshipStartDateQuery.cs
Outdated
Show resolved
Hide resolved
|
|
||
| if (apprenticeshipStartDateOuterModel.Standard.StandardVersion == null) | ||
| { | ||
| _logger.LogWarning($"No standard version data available for apprenticeshipKey:{request.ApprenticeshipKey}"); |
...S.Apprenticeships.UnitTests/Application/Apprenticeship/WhenGettingApprenticeshipStartDate.cs
Show resolved
Hide resolved
...S.Apprenticeships.UnitTests/Application/Apprenticeship/WhenGettingApprenticeshipStartDate.cs
Show resolved
Hide resolved
dinathain
approved these changes
Apr 22, 2024
…rt date object when this is the case
…sFundingAgency/das-apim-endpoints into FLP-606-validate-standard-versions
dinathain
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.