CSP-1392: POST Permissions Endpoint #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shaun-downey-education
commented
Jun 6, 2024
shaun-downey-education
commented
- Added a new endpoint to the PermissionsController.cs file to manage the adding a updating of provider permissions.
MarkFCain
reviewed
Jun 13, 2024
src/SFA.DAS.PR.Application/Common/Validators/OperationsValidator.cs
Outdated
Show resolved
Hide resolved
MarkFCain
reviewed
Jun 13, 2024
...A.DAS.PR.Application/Permissions/Commands/PostPermissions/PostPermissionsCommandValidator.cs
Outdated
Show resolved
Hide resolved
MarkFCain
reviewed
Jun 13, 2024
DevenKShah
reviewed
Jun 13, 2024
src/SFA.DAS.PR.Data/EntityConfiguration/PermissionsAuditConfiguration.cs
Outdated
Show resolved
Hide resolved
src/SFA.DAS.PR.Data/Repositories/AccountLegalEntityReadRepository.cs
Outdated
Show resolved
Hide resolved
src/SFA.DAS.PR.Api.UnitTests/Controllers/Permissions/PermissionsControllerPostTests.cs
Outdated
Show resolved
Hide resolved
...SFA.DAS.PR.Application/Permissions/Commands/PostPermissions/PostPermissionsCommandHandler.cs
Outdated
Show resolved
Hide resolved
...SFA.DAS.PR.Application/Permissions/Commands/PostPermissions/PostPermissionsCommandHandler.cs
Outdated
Show resolved
Hide resolved
...SFA.DAS.PR.Application/Permissions/Commands/PostPermissions/PostPermissionsCommandHandler.cs
Outdated
Show resolved
Hide resolved
...SFA.DAS.PR.Application/Permissions/Commands/PostPermissions/PostPermissionsCommandHandler.cs
Outdated
Show resolved
Hide resolved
...SFA.DAS.PR.Application/Permissions/Commands/PostPermissions/PostPermissionsCommandHandler.cs
Outdated
Show resolved
Hide resolved
DevenKShah
reviewed
Jun 14, 2024
src/SFA.DAS.PR.Api.UnitTests/Controllers/Permissions/PermissionsControllerGetTests.cs
Outdated
Show resolved
Hide resolved
DevenKShah
reviewed
Jun 14, 2024
src/SFA.DAS.PR.Api.UnitTests/Controllers/Permissions/PermissionsControllerTests.cs
Outdated
Show resolved
Hide resolved
…troller endpoint.
…iesReadRepository.cs & AccountLegalEntityReadRepository.cs.
…sions to add to array.
DevenKShah
approved these changes
Jun 19, 2024
Comment on lines
+7
to
+9
| Task<AccountLegalEntity?> GetAccountLegalEntity(long accountLegalEntityId, CancellationToken cancellationToken); | ||
| Task<List<AccountLegalEntity>> GetAccountLegalEntities(long accountId, CancellationToken cancellationToken); | ||
| Task<bool> AccountLegalEntityExists(long accountLegalEntityId, CancellationToken cancellationToken); |
There was a problem hiding this comment.
Essentially GetAccountLegalEntity and AccountLegalEntityExists are the same, a null check can be done instead of two separate methods
|
|
||
| public interface IPermissionsAuditWriteRepository | ||
| { | ||
| Task RecordPermissionsAudit(PermissionsAudit permissionsAudit, CancellationToken cancellationToken); |
There was a problem hiding this comment.
Create instead of Record, we need to be consistent in this naming convention
| { | ||
| public async Task RecordPermissionsAudit(PermissionsAudit permissionsAudit, CancellationToken cancellationToken) | ||
| { | ||
| await providerRelationshipsDataContext.PermissionsAudit.AddAsync(permissionsAudit, cancellationToken); |
There was a problem hiding this comment.
again AddAsync is not needed here, this will result in additional thread for no benefit.
|
shaun-downey-education
deleted the
CSP-1392-post-permissions-endpoint-merge
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.