Feature/facd 467 #767
Open
Feature/facd 467 #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…22-07-07 Release candidate 2022 07 07 - DYSAC work
…ontainers-exam-results
Adjusting image banner for mobile view and cleaning up image banner header
…ize-within-infomation-container-on-desktop-exam-resutlts NCSLT-1026 pfontsize
…ull-width-image-component-exam-results] NCSLT-1025 improve full width image component [exam results]
NCSLT-1021 (and NCSLT-1022)
…ttom-spacing-on-grey-containers-exam-results NCSLT-1023-remove-bottom-spacing-on-grey-containers-exam-results
Addition of LTCE survey code
…ht. Also reduced the gap size between cards in get the jump page.
* Feature/ltce 119 (#742) * Added survey styles to survey rating file and modified js selectors in ltce survey * Fixed selector reference on line 14 * Added bottom: 0px to hopefully fix sticky not working * Added display: none; to the survey styles by default (this is to allow Google Optimize to work properly) * Commented out condition to display popup survey, as this interferes with Google Optimize scripts * Possible fix for js error in dev * Hopeful fix for the js error in browser * added padding to survey and max-width to survey-container class to ensure width sizing is uniform to the rest of the site content * Removed padding and added calculated width for possible styling fix * Moved survey varible from localStorage to sessionStorage * Added cookie for sitewide survey display lock - this is currently set to 5 mins, but we have the desired 28 days expiry set in line 3 (commented out for now) * Fixed typo in code commit * Removed commented lines and console.log commands (for tidier code) * Feature/ltce 119 into hotfix-19 (SMART survey display fix) (#743) * Added survey styles to survey rating file and modified js selectors in ltce survey * Fixed selector reference on line 14 * Added bottom: 0px to hopefully fix sticky not working * Added display: none; to the survey styles by default (this is to allow Google Optimize to work properly) * Commented out condition to display popup survey, as this interferes with Google Optimize scripts * Possible fix for js error in dev * Hopeful fix for the js error in browser * added padding to survey and max-width to survey-container class to ensure width sizing is uniform to the rest of the site content * Removed padding and added calculated width for possible styling fix * Moved survey varible from localStorage to sessionStorage * Added cookie for sitewide survey display lock - this is currently set to 5 mins, but we have the desired 28 days expiry set in line 3 (commented out for now) * Fixed typo in code commit * Removed commented lines and console.log commands (for tidier code) * Added sitewide survey cookie to check before displaying SMART survey * Added z-index to sitewide survey Co-authored-by: Joe Hudson-Small <Joehs@me.com> * Amended solution to LTCE-119 to Hotfix 19 (#744) * Added survey styles to survey rating file and modified js selectors in ltce survey * Fixed selector reference on line 14 * Added bottom: 0px to hopefully fix sticky not working * Added display: none; to the survey styles by default (this is to allow Google Optimize to work properly) * Commented out condition to display popup survey, as this interferes with Google Optimize scripts * Possible fix for js error in dev * Hopeful fix for the js error in browser * added padding to survey and max-width to survey-container class to ensure width sizing is uniform to the rest of the site content * Removed padding and added calculated width for possible styling fix * Moved survey varible from localStorage to sessionStorage * Added cookie for sitewide survey display lock - this is currently set to 5 mins, but we have the desired 28 days expiry set in line 3 (commented out for now) * Fixed typo in code commit * Removed commented lines and console.log commands (for tidier code) * Added sitewide survey cookie to check before displaying SMART survey * Added z-index to sitewide survey * Moved survey cookie check to jp-feedback js and reverted dfcdigital file in gds * reverts change from gds_toolkit * more amendments to .js Co-authored-by: Thomas Slatter <thomas.slatter@netcompany.com> * removes change from gds_toolkit * Tom's latest changes for LTCE-119 into Hotfix 19 (#745) * Added survey styles to survey rating file and modified js selectors in ltce survey * Fixed selector reference on line 14 * Added bottom: 0px to hopefully fix sticky not working * Added display: none; to the survey styles by default (this is to allow Google Optimize to work properly) * Commented out condition to display popup survey, as this interferes with Google Optimize scripts * Possible fix for js error in dev * Hopeful fix for the js error in browser * added padding to survey and max-width to survey-container class to ensure width sizing is uniform to the rest of the site content * Removed padding and added calculated width for possible styling fix * Moved survey varible from localStorage to sessionStorage * Added cookie for sitewide survey display lock - this is currently set to 5 mins, but we have the desired 28 days expiry set in line 3 (commented out for now) * Fixed typo in code commit * Removed commented lines and console.log commands (for tidier code) * Added sitewide survey cookie to check before displaying SMART survey * Added z-index to sitewide survey * Moved survey cookie check to jp-feedback js and reverted dfcdigital file in gds * reverts change from gds_toolkit * more amendments to .js * Added event listener for survey items - hitting enter when star or close is seleted submits survey response Co-authored-by: Thomas Slatter <thomas.slatter@netcompany.com> * Screenreader support for survey popups LTCE-119 into Hotfix 19 (#746) * Added survey styles to survey rating file and modified js selectors in ltce survey * Fixed selector reference on line 14 * Added bottom: 0px to hopefully fix sticky not working * Added display: none; to the survey styles by default (this is to allow Google Optimize to work properly) * Commented out condition to display popup survey, as this interferes with Google Optimize scripts * Possible fix for js error in dev * Hopeful fix for the js error in browser * added padding to survey and max-width to survey-container class to ensure width sizing is uniform to the rest of the site content * Removed padding and added calculated width for possible styling fix * Moved survey varible from localStorage to sessionStorage * Added cookie for sitewide survey display lock - this is currently set to 5 mins, but we have the desired 28 days expiry set in line 3 (commented out for now) * Fixed typo in code commit * Removed commented lines and console.log commands (for tidier code) * Added sitewide survey cookie to check before displaying SMART survey * Added z-index to sitewide survey * Moved survey cookie check to jp-feedback js and reverted dfcdigital file in gds * reverts change from gds_toolkit * more amendments to .js * Added event listener for survey items - hitting enter when star or close is seleted submits survey response * Styling fix and js changes to reflect on star IDs change in composite-shell Co-authored-by: Thomas Slatter <thomas.slatter@netcompany.com> * LTCE-119 styling fix (#747) * Added survey styles to survey rating file and modified js selectors in ltce survey * Fixed selector reference on line 14 * Added bottom: 0px to hopefully fix sticky not working * Added display: none; to the survey styles by default (this is to allow Google Optimize to work properly) * Commented out condition to display popup survey, as this interferes with Google Optimize scripts * Possible fix for js error in dev * Hopeful fix for the js error in browser * added padding to survey and max-width to survey-container class to ensure width sizing is uniform to the rest of the site content * Removed padding and added calculated width for possible styling fix * Moved survey varible from localStorage to sessionStorage * Added cookie for sitewide survey display lock - this is currently set to 5 mins, but we have the desired 28 days expiry set in line 3 (commented out for now) * Fixed typo in code commit * Removed commented lines and console.log commands (for tidier code) * Added sitewide survey cookie to check before displaying SMART survey * Added z-index to sitewide survey * Moved survey cookie check to jp-feedback js and reverted dfcdigital file in gds * reverts change from gds_toolkit * more amendments to .js * Added event listener for survey items - hitting enter when star or close is seleted submits survey response * Styling fix and js changes to reflect on star IDs change in composite-shell * Removed padding on x close <a> Co-authored-by: Thomas Slatter <thomas.slatter@netcompany.com> * Commit final survey expiration time Co-authored-by: tslatternet <114909672+tslatternet@users.noreply.github.com> Co-authored-by: Thomas Slatter <thomas.slatter@netcompany.com>
Feature/fac dym
Add guard against numeric additions to input box with existing autocomplete dropdown
set location autodropdown to width of location textbox on landing page
feature/facd-465
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worked on location input issue for mobile devices.