Ncslt 3965 master #790
Open
Ncslt 3965 master #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…22-07-07 Release candidate 2022 07 07 - DYSAC work
…ontainers-exam-results
Adjusting image banner for mobile view and cleaning up image banner header
…ize-within-infomation-container-on-desktop-exam-resutlts NCSLT-1026 pfontsize
…ull-width-image-component-exam-results] NCSLT-1025 improve full width image component [exam results]
NCSLT-1021 (and NCSLT-1022)
…ttom-spacing-on-grey-containers-exam-results NCSLT-1023-remove-bottom-spacing-on-grey-containers-exam-results
Addition of LTCE survey code
…ht. Also reduced the gap size between cards in get the jump page.
Fixed clear filter bug
Co-authored-by: Syed Shah <syed.naeem@gmail.com> Co-authored-by: syedatmethods <111760797+syedatmethods@users.noreply.github.com>
Fixed mobile devices issue
removed bullet from fac-govuk-list class
Additional courses in your area
* removed bullet from fac-govuk-list class * Fixed contactus link * Remove CSS class selectors affecting other NCS landing pages Co-authored-by: syedatmethods <syed.shah@methods.co.uk> Co-authored-by: Christopher L <demedial@gmail.com> Co-authored-by: Syed Shah <111760797+syedatmethods@users.noreply.github.com>
…/release-18-fac-beta-1-updated Merge final fac-beta 1 (v7) changes into fac-beta 2 feature branch
Strip distance parameter from link back to FAC homepage by pointing to href id
Revert clear filter styling from button back to hyperlink
…e spacing between distance dropdown
Revert 'Clear filters' hyperlink from div back to p html tag to create spacing between distance dropdown
* completed some mobile tweeks (#636) * Dfc 14318 qual levels * tablet tweeks (#638) * Updated tweeks for various devices (#640) * Clear filters Change for FAC * changes to mobile (#643) * changes to mobile * minor change * fixed styling (#646) * Created appInsights event for cookie status * sorted styling errors (#649) * Created Gtag event for cookie policy change * Ypfc latestchanges (#656) * wip * wip * wip * further changes (#657) * final changes (#658) * correct silly mistake (#659) * [FT2-1343] AJAX-effect loading (#661) * FT2-1377 + FT2-1378 - Fix some small styling issues (#662) * Fixing error (#663) * completed some mobile tweeks (#636) * tablet tweeks (#638) * Updated tweeks for various devices (#640) * changes to mobile (#643) * changes to mobile * minor change * fixed styling (#646) * Created appInsights event for cookie status * sorted styling errors * Fix for Issue nr 1: outline appearing twice on mobiles. * Issue 8 fix: missaligned skills for life logo * Fix for issue nr 3: overlaying tiles * Fix for Issue nr 4: text beyond border of tiles * Fix for issue 6. Header image being distorted on mobiles * Issue nr 3: fix for small wcreen width. T-levels tile still to be done. * fix for issue 3. Ready for test * Created LTCEsurveys.JS Javascript to allow button functionality * update concat file to include LTCEsurvey * update to include LTCE survey in GDS * FT2-1400 - Change for DYSAC side menu (#679) * FT2-1400 - Additional section (#680) * Fixed print links (#681) * FT2-1545 (#691) * FT2-1340 - Some colour differences (#692) * FT2-1340 - Attempt #2 (#693) * Moving h2 header sass definition * Created survey-rating.scss * updated all.scss to include survey rating CSS * updated _survey-rating This update allows the feedback mechanism to be the correct size * Script for esfa page added. (#716) * Updated find a course search functionality. Added images for the FAC home page * updated empty variables check as current node version doesn't support Nullish Coalescing * Added css and images for the find a course home page. * Renamed _typography file * Revert "Bump jquery from 3.4.1 to 3.5.0 in /src/nationalcareers_toolkit (#145)" This reverts commit b7c85b1. * Reverted the package.josn file * Added images for Help with choices page * added functionality to clear filters in FAC * Apply pagination changes * Added paging styles from gov.uk * commented import * Removed the comments * Added margin-fix css * Updated fac for free course search * FAC search auto suggest will appear after 2 characters. * REmoved suggested location as element doesn't exists. * Added css for pagination * Applied fix for location search. Update search no resuult message * Added media for max-width * Format document. * removed media * added media for updated govuk-list * Updated css for the iOS clancel button * image update * Find a course images changes * Applied back button fix for find a course * Applied fix for fac location & course search fields * Removed the serach conditions * Added logs for iOS testing * Fixed mobile devices bugs * Add unload event * Added fix of iOS * Updated content and images for beta1 * set landing page when search is empty * Fixed back button bug * Fixed level3 search filter bug * Fixed search * updated search * Removed search result show/hide * Set fac landing page * updated fac ajaxrequest * Added search method * Fixed sorting * Updated for distance selector * Removed filter-form from submit function * Moved search click button at top * Add guard against numeric additions to input box with existing autocomplete dropdown * set location autodropdown to width of location textbox on landing page * Search on browser window adjustment to redraw autocomplete dropdown * Add short timeout guard to reduce amount of calls made on window resize * Removed location input blur function. * Renamed govuk-list class as it was conflicting for contact-us page. * Fixd clear filter bug * Fixd clear filter bug (#770) Co-authored-by: Syed Shah <syed.naeem@gmail.com> Co-authored-by: syedatmethods <111760797+syedatmethods@users.noreply.github.com> * Fixed mobile devices issue * Removed the commented line * Merge latest fac-beta 1 changes into release branch (v7) (#776) * removed bullet from fac-govuk-list class * Fixed contactus link * Remove CSS class selectors affecting other NCS landing pages Co-authored-by: syedatmethods <syed.shah@methods.co.uk> Co-authored-by: Christopher L <demedial@gmail.com> Co-authored-by: Syed Shah <111760797+syedatmethods@users.noreply.github.com> --------- Co-authored-by: snipered2003 <snipered@hotmail.com> Co-authored-by: Stephen Yates <SYatesSoftware@gmail.com> Co-authored-by: Stephen Yates <51610930+syatessoftware@users.noreply.github.com> Co-authored-by: kmalik1978 <32101451+kmalik1978@users.noreply.github.com> Co-authored-by: ryanbarlowmethods <85944633+ryanbarlowmethods@users.noreply.github.com> Co-authored-by: LarryOG <lary.larkowski@gmail.com> Co-authored-by: SamDonnelly23 <91659794+SamDonnelly23@users.noreply.github.com> Co-authored-by: WillTuson <99195610+WillTuson@users.noreply.github.com> Co-authored-by: Andy Rose <andy@cyberian.co.uk> Co-authored-by: ravi-methods <83820221+ravi-methods@users.noreply.github.com> Co-authored-by: syedatmethods <syed.shah@methods.co.uk> Co-authored-by: syedatmethods <111760797+syedatmethods@users.noreply.github.com> Co-authored-by: Syed Shah <syed.naeem@gmail.com> Co-authored-by: Chris Ly <chris.ly@education.gov.uk> Co-authored-by: Christopher L <demedial@gmail.com>
… location in the DYM list (#782)
Revert "Strip distance parameter from link back to FAC homepage by pointing to href id"
…/hotfix-21 Merge Release 21 into master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.