Skip to content
This repository has been archived by the owner on Nov 28, 2020. It is now read-only.

Make sure colour level is set to 0 when a bulb is identified as off. #1

Closed
wants to merge 1 commit into from

Conversation

Jaffa
Copy link
Contributor

@Jaffa Jaffa commented Jun 2, 2019

When a bulb is set to off, the level is set to 0. However, not for :colour, because of the shortcircuiting in the bridge handler.

This pull request removes some of the shortcircuiting, and the :colour level is appropriately set to 0.

This allows :colour channel to be used as a brightness equivalent properly.

@Skinah
Copy link
Owner

Skinah commented Jun 4, 2019

Thanks for the Push, give me a few days to a week to find some time to test this out and look at it in more depth. Very busy at the moment. If you are going to make any changes to the code can you first discuss them as I may refuse the changes or wish they were offered as a user changeable option causing the work to be fully redone in a different way.

In this case I think what you are doing is discussed in this post here? What are your thoughts after reading the contents of this post?

https://community.openhab.org/t/espmilighthub-new-binding-for-milight-limitlessled-and-easybulb/39720/288

I am happy to add features that people want, but usually I like to give the user the option to turn it on and off if there is a chance some will want it and others will not.

Thanks for your input and I have edited the readme with some extra info and removed the lowercase hex numbers from the examples.

@Jaffa
Copy link
Contributor Author

Jaffa commented Jun 4, 2019 via email

@Skinah
Copy link
Owner

Skinah commented Dec 8, 2019

Do you still require this? I am updating the code at the moment and will look at this if it is still something you are interested in. Let me know any info that would be useful and I can look at which way forward works for most people.

@Jaffa
Copy link
Contributor Author

Jaffa commented Dec 9, 2019

Yes, thanks @Skinah - still require this, and I (personally) think it should be the default if you make it an option, based on Hue bulbs and similar that are also ColorItems.

@Skinah
Copy link
Owner

Skinah commented Dec 28, 2019

I will call this option LEVEL_FOLLOWS_COLOUR and the default will be the way you are wanting it to be so this will be a breaking change for some users until they change the setting. I agree it should be the default as a number of people have considered this to be a bug, so if that is the case it should be default with the way I like it as an optional feature.

Should have a build out in a few hours time after I test the changes you suggested and make some other requested changes.

Closing this PR as it is faster for me to do it this way as I am not good with Git.

@Skinah Skinah closed this Dec 28, 2019
@butteryak butteryak mentioned this pull request Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants